fix: send asset metadata create_time & update_time to Compass #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
force-pushed
the
create_update_time
branch
from
b2a89e0 to
1100b00
Compare
Contributor
Author
|
@StewartJingga this PR can be reviewed now. Have verified changes to the best of my ability. Will remove the draft status once raystack/proton#191 is merged and the proton commit is updated. |
Compass request data structure did not support sending the create_time
and update_time parsed from data present in extractors. For example,
this would be the time a table was created in a database and the time it
was last updated at.
- Update Proton's commit ID to pull in changes that add create_time and
update_time fields in each of the asset metadata types - table, user,
topic etc.
- Populate Asset.Data.{CreateTime, UpdateTime} and stop populating
Asset.{CreateTime,UpdateTime} (these fields are used by the system to
track the first and last injestion run that inserted/updated the
asset).
sudo-suhas
force-pushed
the
create_update_time
branch
from
1100b00 to
92ad8ce
Compare
StewartJingga
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compass request data structure did not support sending the create_time and update_time parsed from data present in extractors. For example, this would be the time a table was created in a database and the time it was last updated at.
Depends on raystack/proton#191.
Closes #409.