fix: accept and use scope for generating recipe #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
commented
Aug 30, 2022
StewartJingga
requested changes
Sep 5, 2022
sudo-suhas
force-pushed
the
gen-recipe-with-scope
branch
from
a232e38 to
dd95577
Compare
StewartJingga
approved these changes
Sep 8, 2022
StewartJingga
requested changes
Sep 8, 2022
Add new mandatory flag --scope to 'meteor new recipe' command for
creating a sample recipe and use the provided scope for generating the
recipe.
Rename field for source in the generated recipe - source.{type => name}.
BREAKING CHANGE:
- Change method signature for generator.Recipe().
- Remove generator.Template struct type from public scope.
sudo-suhas
force-pushed
the
gen-recipe-with-scope
branch
from
dd95577 to
283043e
Compare
StewartJingga
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new mandatory flag --scope to 'meteor new recipe' command for
creating a sample recipe and use the provided scope for generating the
recipe.
BREAKING CHANGE: Method signature for generator.Recipe() changed.
Closes #402.