Skip to content

fix(bigquery): sanitize unicode null sequence #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StewartJingga merged 2 commits into from
Jul 4, 2022
Merged

fix(bigquery): sanitize unicode null sequence #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12eb542
fix(bigquery): sanitize unicode sequence
bsushmith Jul 4, 2022
8c05d24
chore: add makefile lint target
bsushmith Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,7 @@ generate-proto: ## regenerate protos
@echo " > cloning protobuf from odpf/proton"
@echo " > generating protobuf"
@buf generate --template buf.gen.yaml https://github.com/odpf/proton/archive/a0bc6dbf2ad91abfebc4bf5f70e275983109baca.zip#strip_components=1 --path odpf/assets
@echo " > protobuf compilation finished"
@echo " > protobuf compilation finished"

lint: ## Lint with golangci-lint
golangci-lint run
4 changes: 4 additions & 0 deletions plugins/extractors/bigquery/bigquery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,10 @@ func (e *Extractor) buildPreview(ctx context.Context, t *bigquery.Table) (previe
err = errors.Wrapf(err, "error marshalling \"%s\" to json", t.FullyQualifiedName())
return
}
// sanitize unicode sequence
// replace unicode null characters with "null" string to ensure downstream would not have issues dealing with unicode null characters
jsonString := strings.ReplaceAll(string(jsonBytes), "\\u0000", "null")
jsonBytes = []byte(jsonString)
err = json.Unmarshal(jsonBytes, &temp)
if err != nil {
err = errors.Wrapf(err, "error marshalling \"%s\" to json", t.FullyQualifiedName())
Expand Down