-
Notifications
You must be signed in to change notification settings - Fork 46
fix: sink all records to file after stream closes #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@GrayFlash are we making |
|
@GrayFlash When there is an What it means is, even before sinking process, if there is an issue on other plugins configuration, we would already remove the Will that behaviour be expected? cc: @bsushmith @mabdh @ravisuhag if not, one thing we could do it, we can sink the result to a temporary file, and once everything is done, we replace the |
|
@StewartJingga I think that should be fine as the user has already taken the decision of overriding it. Extraction is happening post that decision. |
closes #366