Skip to content

Conversation

@GrayFlash
Copy link
Member

@GrayFlash GrayFlash commented Jun 16, 2022

closes #366

@GrayFlash GrayFlash requested review from StewartJingga and mabdh June 16, 2022 04:20
@GrayFlash GrayFlash self-assigned this Jun 16, 2022
@mabdh
Copy link
Member

mabdh commented Jun 20, 2022

@GrayFlash are we making append vs overwrite configurable by user?

@StewartJingga
Copy link
Contributor

StewartJingga commented Jun 22, 2022

@GrayFlash When there is an existing file on overwrite mode, it will now remove the existing file on initialization.

What it means is, even before sinking process, if there is an issue on other plugins configuration, we would already remove the existing file.

Will that behaviour be expected? cc: @bsushmith @mabdh @ravisuhag

if not, one thing we could do it, we can sink the result to a temporary file, and once everything is done, we replace the existing file with the temp file.

@ravisuhag
Copy link
Member

@StewartJingga I think that should be fine as the user has already taken the decision of overriding it. Extraction is happening post that decision.

@ravisuhag ravisuhag merged commit 63b3ded into main Jun 24, 2022
@ravisuhag ravisuhag deleted the fix-file-sink branch June 24, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

file sink overwrites rather than append

6 participants