Skip to content

Conversation

@StewartJingga
Copy link
Contributor

new mandatory config to label extracted metabase metadata.

source:
  name: metabase
  config:
    ...
    instance_label: my-metabase

this will be used as the urn component like below

{
  "urn": "metabase::my-metabase/dashboard/192"
}

@GrayFlash GrayFlash self-requested a review May 31, 2022 03:30
@GrayFlash
Copy link
Member

@StewartJingga the test for elasticsearch fails in cli as well as my local. Can you check it once??

@GrayFlash
Copy link
Member

sorry it passed locally, I guess the order in which we get output fields is inconsistent. Shouldn’t be an issue for this PR.

@mabdh mabdh merged commit 76ee919 into main May 31, 2022
@mabdh mabdh deleted the metabase-label branch May 31, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(metabase): use alias for urn generation instead of using instance's host

5 participants