Skip to content

feat: add snowflake extractor #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mabdh merged 7 commits into from
Mar 16, 2022
Merged

feat: add snowflake extractor #324

mabdh merged 7 commits into from
Mar 16, 2022

Conversation

@scortier
Copy link
Member

@scortier scortier commented Mar 1, 2022 •
edited by mabdh
Loading

Deliverables

  • add unit tests (Tested with dummy data present in snowflake trial version account)
  • add extractor
  • add README.md in plugins/extractors/snowflake, defining output
  • register your extractor plugins/extractors/populate.go
  • add extractor the extractor list in docs/reference/extractor.md

Output

Table

Field Sample Value
urn my_database.my_table
name my_table
source presto
schema [][Column]

Column

Field Sample Value
name total_price
description item's total price
data_type decimal
is_nullable true

Related Issue

Issue #89

@scortier scortier marked this pull request as draft March 1, 2022 08:28
@ravisuhag ravisuhag linked an issue Mar 1, 2022 that may be closed by this pull request
Add metadata extractor for snowflake #89
Closed
5 tasks
@scortier scortier force-pushed the feat_snowflake-extractor branch from 4e63872 to 8e964c0 Compare March 2, 2022 05:27
@scortier scortier self-assigned this Mar 3, 2022
@scortier scortier marked this pull request as ready for review March 3, 2022 06:16
@mabdh mabdh added the extractor Add new extractor label Mar 8, 2022
@scortier scortier marked this pull request as draft March 8, 2022 06:07
@mabdh mabdh force-pushed the feat_snowflake-extractor branch from dcfdbeb to 1be51fb Compare March 15, 2022 11:41
@mabdh mabdh marked this pull request as ready for review March 15, 2022 11:44
@scortier scortier force-pushed the feat_snowflake-extractor branch from 18b5822 to 2ba0b80 Compare March 15, 2022 14:12
@mabdh mabdh force-pushed the feat_snowflake-extractor branch from 2ba0b80 to f64d24a Compare March 15, 2022 14:31
@scortier scortier force-pushed the feat_snowflake-extractor branch from 37b0da7 to fb2e2e3 Compare March 15, 2022 17:38
@mabdh mabdh merged commit c825f67 into main Mar 16, 2022
@mabdh mabdh deleted the feat_snowflake-extractor branch March 16, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

@mabdh mabdh Awaiting requested review from mabdh

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees

@scortier scortier

Labels

extractor Add new extractor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add metadata extractor for snowflake

3 participants

@scortier @mabdh