Skip to content

Conversation

@scortier
Copy link
Member

@scortier scortier commented Oct 1, 2021

No description provided.

@scortier scortier marked this pull request as draft October 1, 2021 04:27
@scortier scortier force-pushed the integration-test branch 2 times, most recently from ae987ed to 5c7bfe2 Compare October 4, 2021 18:51
@scortier scortier changed the title Add integration tests to test run recipes Add e2e testing to test run recipes Oct 4, 2021
@scortier scortier self-assigned this Oct 5, 2021
@scortier scortier added core Core framework feature enhancement New feature or request labels Oct 5, 2021
@ravisuhag
Copy link
Member

@scortier Let's move the e2e tests to the root test folder only. test/e2e

@StewartJingga
Copy link
Contributor

@ravisuhag right now test folder is used for test utilities, should we somehow restructure it?

the perks of having e2e to be it's own package is we can isolate the test easier.

@ravisuhag
Copy link
Member

ravisuhag commented Oct 5, 2021

@ravisuhag right now test folder is used for test utilities, should we somehow restructure it?

the perks of having e2e to be it's own package is we can isolate the test easier.

It will still be an isolated package inside test. test/e2e wdyt?

@scortier scortier marked this pull request as ready for review October 5, 2021 06:19
@scortier scortier requested a review from ravisuhag October 5, 2021 06:19
@StewartJingga
Copy link
Contributor

we could do that as far as isolation goes.

but how would you define test package/folder now?
doing so will make test package to be

  • a test utilities package required/depended by other packages
  • a folder containing meteor tests (e2e, etc)

or if you want e2e to be inside test folder, maybe we can have it like this:

├── test
│   ├── utils
│   │   ├── dockertest.go
│   │   ├── logger.go
│   ├── mocks
│   │   ├── plugin.go
│   ├── e2e
│   │   ├── **/*_test.go

wdyt?

@ravisuhag
Copy link
Member

we could do that as far as isolation goes.

but how would you define test package/folder now? doing so will make test package to be

  • a test utilities package required/depended by other packages
  • a folder containing meteor tests (e2e, etc)

or if you want e2e to be inside test folder, maybe we can have it like this:

├── test
│   ├── utils
│   │   ├── dockertest.go
│   │   ├── logger.go
│   ├── mocks
│   │   ├── plugin.go
│   ├── e2e
│   │   ├── **/*_test.go

wdyt?

@scortier Yes, we can go with this proposed approach.

@scortier scortier linked an issue Oct 5, 2021 that may be closed by this pull request
@scortier scortier requested a review from StewartJingga October 7, 2021 13:03
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scortier Can you add a Make command to run this e2e test.

make test-e2e

And also update our test github action to also run the new command.

@StewartJingga StewartJingga merged commit 97e3e44 into main Oct 8, 2021
@StewartJingga StewartJingga deleted the integration-test branch October 8, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core framework feature enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add end to end testing to test run recipes

4 participants