-
Notifications
You must be signed in to change notification settings - Fork 46
Add e2e testing to test run recipes #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae987ed to
5c7bfe2
Compare
17bd759 to
c6e476d
Compare
c6e476d to
2b6a1cf
Compare
|
@scortier Let's move the e2e tests to the root test folder only. |
|
@ravisuhag right now the perks of having e2e to be it's own package is we can isolate the test easier. |
It will still be an isolated package inside test. |
|
we could do that as far as isolation goes. but how would you define test package/folder now?
or if you want e2e to be inside ├── test
│ ├── utils
│ │ ├── dockertest.go
│ │ ├── logger.go
│ ├── mocks
│ │ ├── plugin.go
│ ├── e2e
│ │ ├── **/*_test.gowdyt? |
@scortier Yes, we can go with this proposed approach. |
StewartJingga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scortier Can you add a Make command to run this e2e test.
make test-e2e
And also update our test github action to also run the new command.
0750d34 to
45df5c8
Compare
No description provided.