Skip to content

feat: add superset extractor #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StewartJingga merged 1 commit into from
Sep 23, 2021
Merged

feat: add superset extractor #222

StewartJingga merged 1 commit into from
Sep 23, 2021

Conversation

@scortier
Copy link
Member

@scortier scortier commented Sep 17, 2021 •
edited
Loading

Deliverables

  • add unit tests ( TODO: Create user in superset )
  • add extractor
  • add README.md in plugins/extractors/superset, defining output
  • register your extractor plugins/extractors/populate.go
  • add extractor the extractor list in docs/reference/extractor.md

Outputs

Field Sample Value
resource.urn superset.dashboard_name
resource.name dashboard_name
resource.service superset
resource.url dashboard_url

Chart

Field Sample Value
name chart_name
dashboard_source superset
description chart_description
url chart_url
datasource chart_datasource
dashboard_urn dashboard:dashboard_id

Related Issues

Issue #90

@scortier scortier marked this pull request as draft September 17, 2021 20:01
@scortier scortier force-pushed the feat_superset-extractor branch from 4a6a525 to 6fe5b26 Compare September 17, 2021 20:01
ravisuhag
ravisuhag reviewed Sep 19, 2021
View reviewed changes
@scortier scortier force-pushed the feat_superset-extractor branch from aa9b4cb to 798d504 Compare September 21, 2021 20:59
@scortier scortier linked an issue Sep 22, 2021 that may be closed by this pull request
Add metadata extractor for superset #90
Closed
5 tasks
@scortier scortier marked this pull request as ready for review September 22, 2021 06:47
@scortier scortier changed the title feat: init superset extractor feat: add superset extractor Sep 22, 2021
StewartJingga
StewartJingga requested changes Sep 23, 2021
View reviewed changes
@scortier scortier force-pushed the feat_superset-extractor branch from 342a6b3 to 410b76b Compare September 23, 2021 11:20
StewartJingga
StewartJingga approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StewartJingga StewartJingga merged commit 3129135 into main Sep 23, 2021
@StewartJingga StewartJingga deleted the feat_superset-extractor branch September 23, 2021 19:03
@scortier scortier self-assigned this Sep 24, 2021
@scortier scortier added the extractor Add new extractor label Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees

@scortier scortier

Labels

extractor Add new extractor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add metadata extractor for superset

4 participants

@scortier @ravisuhag @StewartJingga