Skip to content

Conversation

@ravisuhag
Copy link
Member

closes #207

@ravisuhag ravisuhag added the bug Something isn't working label Sep 17, 2021
@ravisuhag ravisuhag self-assigned this Sep 17, 2021
@StewartJingga
Copy link
Contributor

@ravisuhag i wonder if recipe generator can be handled in the recipe packages, so it would be like recipe.Build().

But it seems like it would mess recipe package dependencies.

@ravisuhag
Copy link
Member Author

@ravisuhag i wonder if recipe generator can be handled in the recipe packages, so it would be like recipe.Build().

But it seems like it would mess recipe package dependencies.

Had the same thought and same concern. :) So kept it separate. I will add a note to consider this future if it makes sense.

Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but for handling indentation in the template, I was thinking to utilise go template pipeline feature.

so it would be like this

config:
{{ $value | indent 6 }}

similar to how helm handles it.

tried to do it on local but had to change a few things in all the plugins to achieve that, we can treat it as a good to have for now.

@ravisuhag ravisuhag merged commit cab327b into main Sep 23, 2021
@ravisuhag ravisuhag deleted the gen-validate branch September 23, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recipe generator returns invalid recipe when no plugin specified

3 participants