feat: migrate remaining admin UI components to ConnectRPC #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 19365674208Details
💛 - Coveralls |
rohilsurana
force-pushed
the
migrate-admin-ui-to-connectrpc
branch
from
12714e2 to
99894f4
Compare
rohilsurana
changed the title
| import { RQLExportRequest } from "@raystack/proton/frontier"; | ||
|
|
||
| const adminClient = clients.admin({ useBinary: false }); | ||
| const adminClient = clients.admin({ useBinary: true }); |
Contributor
There was a problem hiding this comment.
Why have we changed this?
Member
Author
There was a problem hiding this comment.
for smaller network transfers. binary format uses less data.
| onRemove, | ||
| onClose, | ||
| }: RemoveMemberProps) => { | ||
| const [isSubmitting, setIsSubmitting] = useState(false); |
Contributor
There was a problem hiding this comment.
I think we can remove the submitting useState and use the isPending var from useMutation.
Member
Author
There was a problem hiding this comment.
good point, let me do that.
| : "Unknown error"; | ||
| toast.error(`Failed to remove member: ${message}`); | ||
| console.error(error); | ||
| } finally { |
Contributor
There was a problem hiding this comment.
Finallly block will also be removed if using isPending.
| FrontierServiceQueries, | ||
| GetProjectRequestSchema, | ||
| ListRolesRequestSchema, | ||
| } from "@raystack/proton/frontier"; |
Contributor
There was a problem hiding this comment.
@raystack/proton/frontier these two imports can be merged.
| console.error(error); | ||
| } finally { | ||
| setIsProjectRolesLoading(false); | ||
| const { data: projectRoles = [], isLoading: isProjectRolesLoading } = useQuery( |
Contributor
There was a problem hiding this comment.
Error handling required.
| SearchOrganizationProjectsResponse_OrganizationProject, | ||
| } from "@raystack/proton/frontier"; | ||
|
|
||
| import { FrontierServiceQueries, UpdateProjectRequestSchema } from "@raystack/proton/frontier"; |
Contributor
There was a problem hiding this comment.
raystack/proton/frontier imports can be merged
| @@ -1,21 +1,23 @@ | |||
| import { DataTable, EmptyState, Flex } from "@raystack/apsara"; | |||
| import type { DataTableQuery, DataTableSort } from "@raystack/apsara"; | |||
Contributor
There was a problem hiding this comment.
raystack/apsara Imports can be merged here
| }, | ||
| ); | ||
|
|
||
| const { data: plans = [], isLoading: isPlansLoading } = useQuery( |
| console.error(error); | ||
| } finally { | ||
| setIsLoading(false); | ||
| const { data: defaultRoles = [], isLoading: isDefaultRolesLoading } = useQuery( |
| }, []); | ||
| ); | ||
|
|
||
| const { data: organizationRoles = [], isLoading: isOrgRolesLoading } = useQuery( |
…rontier - useRQL: V1Beta1RQLQuery* → RQLQuery* types - getUserName: V1Beta1User → User type - converBillingAddressToString: BillingAccountAddress → BillingAccount_Address, postal_code → postalCode
rohilsurana
force-pushed
the
migrate-admin-ui-to-connectrpc
branch
from
dc923ad to
d2bf4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated admin UI components from REST API (Axios) to ConnectRPC queries and mutations for improved type safety and consistency.
Changes
useQuery,useMutation, anduseInfiniteQueryhooksclients.frontier()andclients.admin()calls with declarative ConnectRPC hooksV1Beta1*to modern types from@raystack/proton/frontierrole_ids→roleIds,postal_code→postalCode)~/api/frontier.ts,~/api/index.ts)Technical Details
create()with RequestSchema types for type-safe request constructionuseInfiniteQueryfor paginated data with RQL supportcreateClient()pattern for imperative calls when hooks aren't suitable (e.g., policy management)Test Plan