Fix issue #22: Incorrect behavior of Line element and Define text as const#24
Open
Dev-Tade wants to merge 3 commits intoraysan5:masterfrom
Open
Fix issue #22: Incorrect behavior of Line element and Define text as const#24Dev-Tade wants to merge 3 commits intoraysan5:masterfrom
Dev-Tade wants to merge 3 commits intoraysan5:masterfrom
Conversation
…luebox, Spinner, Scrollpanel, Colorpicker)
…ontrolTextParam doesn't reference empty text constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue described at #22 where code generation wouldn't generate constant strings for line elements when
Define text as constoption was checked, in the issue I also mention the possibility of other elements maybe having the same issue, those elements are now fixed too.The original issue mentioned a possible improvement so elements with empty text don't generate an empty const string, actually that improvement is necessary for some elements because when the code generated something like
const char *SomeControlName = "";when an empty string like that was passed to some elements could cause certain rendering problems with some parts of the control.Now when the code gen finds an element whose text is "" it doesn't generates a const string and passes NULL as text parameter to the element drawing function (this applies to all controls i belive)