[raudio] Support 24-bit FLACs in LoadMusicStreamFromMemory
#4279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force conversion to 16-bit, same as how it is done in `LoadMusicStream`. This fixes the problem where 24-bit FLACs play silence or broken sound.
Owner
|
@konstruktor227 Nice! Thanks for the review! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading FLAC files using
LoadMusicStreamFromMemory, 24-bit files play either silence (Windows) or extreme noise (Linux, macOS), while 16-bit files work all fine.While debugging this I stumbled on #4058, which recently fixed the same problem in
LoadMusicStreamby forcing conversion to 16-bit.Here simply copying the same fix to
LoadMusicStreamFromMemory, which fixes all the issues with 24-bit files for me.