[rlgl] Adding warnings in case OpenGL 4.3 is not enabled #4202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@MaximKn1 Some of those warnings could spam the log if the functions are called every frame, please, remove the ones from functions that can potentially be called on a frame basis. |
Contributor
Author
|
@raysan5 Removed logging as you suggested, except rlBindImageTexture, because as far as I can tell, there is no way to tell if proper OpenGL version is used for this functionality before calling it. |
Owner
|
@MaximKn1 Thanks for the review! |
Owner
|
@MaximKn1 I'm afraid this PR breaks raylib compilation for web, please, could you review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I added warnings for the functionality related to OpenGL 4.3 features in case GRAPHICS_API_OPENGL_43 is not defined.
Personally, been struggling to make compute shaders work, only to discover that I am not on the correct API version (as the default one is 3.3). I think it is better to add some logging to notify about incorrect OpenGL version. Currently 4.3 related functions are virtually empty if you are not using 4.3 and you can call them even if you are on 3.3. Shader compiler even says it managed to compile a compute shader when using 3.3.