Skip to content

BM Font Extender #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 15, 2023
Merged

BM Font Extender #3536

merged 8 commits into from
Dec 15, 2023

Conversation

@DongkunLee
Copy link
Contributor

@DongkunLee DongkunLee commented Nov 13, 2023

I want Bitmap Font loader is extended.
This code can load multiple atlas.

I wish may it could be helpful to raylib.

@RobLoach
Copy link
Contributor

RobLoach commented Nov 13, 2023

Looks pretty cool. Have been curious about .bmf myself. Looks to bring in a third-party library? Perhaps it could live as an external library quite well... call if raylib-bmfont or something :)

@raysan5
Copy link
Owner

raysan5 commented Nov 13, 2023

@RobLoach Actually it adds support for multi-atlas .fnt xml files, generated using Angel Code BMFont tool. Afair, it was the first font loader implemented in raylib about 10 years ago for bitmap font atlas but only 1 image-atlas was supported. This PR should only address that issue, modifying the LoadBMFont() functions in rtext.c. Afaik, .BMF files are a completely different thing.

@RobLoach
Copy link
Contributor

RobLoach commented Nov 13, 2023

Oh nice! That sounds really cool.

@raysan5
Copy link
Owner

raysan5 commented Dec 1, 2023

@DongkunLee The following file should be removed from the PR to be able to be merged: loadbmfontex.diff

@raysan5
Copy link
Owner

raysan5 commented Dec 11, 2023

@DongkunLee Please, could you remove the loadbmfontex.diff file from the PR to merge?

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 15, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 15, 2023
View reviewed changes
src/rtext.c
Rectangle srcRec = { 0.0f, 0.0f, (float)imWidth, (float)imHeight };
Rectangle destRec = { 0.0f, (float)imHeight*(float)i, (float)imWidth, (float)imHeight };
ImageDraw(&fullFont, imFonts[i], srcRec, destRec, WHITE);
}

Check failure

Code scanning / CodeQL

Overflow in uncontrolled allocation size

This allocation size is derived from [user input (string read by fread)](1) and might overflow.
@raysan5
Copy link
Owner

raysan5 commented Dec 15, 2023

Just reviewed the PR for merging but please note this is not the expected way to contribute to a project. The contributor must ensure the PR is correct and become the owner of its contributions.

@raysan5 raysan5 merged commit 9de7986 into raysan5:master Dec 15, 2023
@chenrui333 chenrui333 mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DongkunLee @RobLoach @raysan5