Update crossbeam-deque to 0.7 #675
Conversation
The only substantive change is to 'take_local_job'. 'Worker::pop` now returns a plain 'Option<T>', so there's no need to loop anymore
|
See also #664 (comment) And note that rayon-core has a note on this regarding compatibility. |
|
@Aaron1011 We've applied your patch in debian, thanks for your work! |
|
@cuviper: If I understand correctly, this PR should now be allowed under the minimum supported Rust version policy. Rust 1.28 (the MSRV of crossbeam-deque) came out just over one year ago. |
cuviper
left a comment
cuviper
left a comment
There was a problem hiding this comment.
Looks good, just a little cleanup on the deque imports. Could you also bump the minor versions and the documentation of the minimum Rust?
|
Curiously, the CI build did actually pass on 1.26 -- but since that support is not documented by |
|
Since they were minor, I went ahead with those changes myself. bors r+ |
675: Update crossbeam-deque to 0.7 r=cuviper a=Aaron1011 The only substantive change is to 'take_local_job'. 'Worker::pop` now returns a plain 'Option<T>', so there's no need to loop anymore Co-authored-by: Aaron Hill <[email protected]> Co-authored-by: Josh Stone <[email protected]>
4 participants
The only substantive change is to 'take_local_job'.
'Worker::pop` now returns a plain 'Option', so there's
no need to loop anymore