-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Initial implementation for pickle5 support #5611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
369477d
initial implementation for pickle5 support
suquark 609ae4c
use a flag to choose different code path
suquark 80ca3dc
fix
suquark fbed681
fix
suquark b476a2e
fix cloudpickle
suquark 2894b91
update cloudpickle version
suquark b58c2b1
disable USE_NEW_SERIALIZER by default
suquark fd67311
lint
suquark 7364f0d
revert changes about pickle5
suquark ed409ac
Merge branch 'master' into pickle5serializaion
pcmoritz 7ad7c41
small fix
pcmoritz 56dd493
lint
pcmoritz 2748512
port on core_worker
pcmoritz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,21 @@ | ||
| from __future__ import absolute_import | ||
| import sys | ||
|
|
||
| from ray.cloudpickle.cloudpickle import * | ||
| # TODO(suquark): This is a temporary flag for | ||
| # the new serialization implementation. | ||
| # Remove it when the old one is deprecated. | ||
| USE_NEW_SERIALIZER = False | ||
|
|
||
| if USE_NEW_SERIALIZER and sys.version_info[:2] >= (3, 8): | ||
| from ray.cloudpickle.cloudpickle_fast import * | ||
| FAST_CLOUDPICKLE_USED = True | ||
| else: | ||
| try: | ||
| import pickle5 | ||
| except ImportError: | ||
| # We need pickle5 backport support for the new serializer. | ||
| USE_NEW_SERIALIZER = False | ||
| from ray.cloudpickle.cloudpickle import * | ||
| FAST_CLOUDPICKLE_USED = False | ||
|
|
||
| __version__ = '1.2.2.dev0' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only be needed for cloudpickle_fast, right? Let's focus on supporting that codepath, so it doesn't break other things.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we we have pickle5 enabled (python3 && python<3.8 && pickle5 installed), then we will try to use the old cloudpickle