Skip to content

[History Server] Add guide to push image to Google Artifact Registry for History Server images#4618

Merged
andrewsykim merged 1 commit intoray-project:masterfrom
chiayi:history-server-imageguide
Mar 19, 2026
Merged

[History Server] Add guide to push image to Google Artifact Registry for History Server images#4618
andrewsykim merged 1 commit intoray-project:masterfrom
chiayi:history-server-imageguide

Conversation

@chiayi
Copy link
Contributor

@chiayi chiayi commented Mar 18, 2026

Why are these changes needed?

Users currently have to build their own history-server image. This just adds a guide to push those images to Google Artifact Registry

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@chiayi
Copy link
Contributor Author

chiayi commented Mar 18, 2026

@andrewsykim PTAL. Adding a readme for pushing image to GAR.

Let me know if it makes sense to put this guide in specific dir or somewhere else. Thank you!

github.com/emicklei/go-restful/v3 v3.13.0
github.com/fsnotify/fsnotify v1.9.0
github.com/fsouza/fake-gcs-server v1.53.1
github.com/google/martian/v3 v3.3.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the go.mod change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure actually, I ran go mod tidy after rebasing. I think it was just never cleaned up when after it wasn't being used anymore.

@chiayi chiayi force-pushed the history-server-imageguide branch from 390e4c1 to 03ba5d1 Compare March 18, 2026 20:29
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiayi chiayi force-pushed the history-server-imageguide branch from 03ba5d1 to 07b4494 Compare March 18, 2026 20:49
@chiayi chiayi force-pushed the history-server-imageguide branch from 07b4494 to 3db5c8b Compare March 18, 2026 20:53
@andrewsykim andrewsykim merged commit fea763a into ray-project:master Mar 19, 2026
31 checks passed
Comment on lines +77 to +80
gcloud artifacts repositories create ${REPO_NAME} \\
--repository-format=docker \\
--location=${REGION} \\
--description="History Server images"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gcloud artifacts repositories create ${REPO_NAME} \\
--repository-format=docker \\
--location=${REGION} \\
--description="History Server images"
gcloud artifacts repositories create ${REPO_NAME} \
--repository-format=docker \
--location=${REGION} \
--description="History Server images"


## Tagging Artifact Registry Images

The image have to follows a specific naming convention for Google Artifact Registry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The image have to follows a specific naming convention for Google Artifact Registry
The image has to follow a specific naming convention for Google Artifact Registry

@chiayi
Copy link
Contributor Author

chiayi commented Mar 19, 2026

Thank @Future-Outlier for catching that. Opened: #4621 for the fixes. PTAL.

rueian added a commit that referenced this pull request Mar 19, 2026
* Disable RayMultiHostIndexing feature for TestReconcile_Multihost_Replicas (#4583)

Signed-off-by: Future-Outlier <[email protected]>

* Disable the field alignment lint check (#4560)

* chore: disable govet fieldalignment lint

Signed-off-by: jinbum9958 <[email protected]>

* chore: remove redundant //nolint:govet comments

Signed-off-by: jinbum9958 <[email protected]>

* chore: restore RayCronJobSpec/RayCronJob comments

Signed-off-by: jinbum9958 <[email protected]>

* chore: restore RayCronJob comment

Signed-off-by: jinbum9958 <[email protected]>

* chore: regenerate artifacts for RayCronJob comment changes

Signed-off-by: jinbum9958 <[email protected]>

---------

Signed-off-by: jinbum9958 <[email protected]>

* Mark RC releases as pre-release in GoReleaser (#4590)

Signed-off-by: Future-Outlier <[email protected]>

* Add example YAML for manually enabling Ray k8s auth (#4582)

Signed-off-by: Andrew Sy Kim <[email protected]>

* [RayService] Rollback Support for Incremental Upgrades (#4109)

* Implement rollback support

Signed-off-by: Ryan O'Leary <[email protected]>

* Fix unit test file

Signed-off-by: Ryan O'Leary <[email protected]>

* Ensure upgrade in progress status is cleared

Signed-off-by: Ryan O'Leary <[email protected]>

* Clarify rollback scenarios and clear pending apps during rollback

Signed-off-by: Ryan O'Leary <[email protected]>

* Fix typo

Signed-off-by: Ryan O'Leary <[email protected]>

* Add guard for rollback to prepare new cluster

Signed-off-by: Ryan O'Leary <[email protected]>

* fix e2e test checking pending cluster name

Signed-off-by: Ryan O'Leary <[email protected]>

* Fix rollback calculation

Signed-off-by: Ryan O'Leary <[email protected]>

* Fix httproute name in test

Signed-off-by: Ryan O'Leary <[email protected]>

* Increase timeout for checking RayCluster deletion

Signed-off-by: Ryan O'Leary <[email protected]>

* Fix rollback check and change httproute equal check so it doesn't always evaluate false

Signed-off-by: Ryan O'Leary <[email protected]>

* Adjust logic to use timestamp of growing cluster

Signed-off-by: Ryan O'Leary <[email protected]>

* Fix naming of vars

Signed-off-by: Ryan O'Leary <[email protected]>

---------

Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>

* [RayService] Promote Incremental Upgrade Feature to Beta (#4599)

Signed-off-by: Ryan O'Leary <[email protected]>

* Revert "[RayService] Promote Incremental Upgrade Feature to Beta (#4599)" (#4602)

This reverts commit 0c8aab9.

* [Github Action] Skip krew-index update for pre-release tags (#4587)

* [CI] Skip krew-index update for pre-release tags

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Claude Opus 4.6 <[email protected]>

* [Helm] update ray-cluster chart to apiVersion: v2 (#4593)

* Update kind configs and docs to v1.29.0 (#4595)

* Remove ingress template support for k8s < 1.19 (#4591)

* [Helm] Update ray-cluster default resource values (#4588)

* update kuberay 1.6.0 helm chart and readme

Signed-off-by: Future-Outlier <[email protected]>

* [Helm] Fix apiserver README chart version and align ray-cluster resource defaults

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* fix ctl test

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: Future-Outlier <[email protected]>

* fix lint

Signed-off-by: Future-Outlier <[email protected]>

* chore: Use RayCluster name as SA name for RBAC auth (#4611)

Signed-off-by: JiangJiaWei1103 <[email protected]>

* Add Google Artifact Registry image build/push guide (#4618)

* [History Server] Fix API response format to match Ray Dashboard frontend schema (#4615)

* [History Server] Fix API response format to match Ray Dashboard frontend schema

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* fix bug 1

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* add comments to explain frontend fields naming issue

Signed-off-by: Future-Outlier <[email protected]>

* fix tests

Signed-off-by: Future-Outlier <[email protected]>

* Add comments

Signed-off-by: Future-Outlier <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* Add frontend reference for this PR

Signed-off-by: Future-Outlier <[email protected]>

* fix codex and cursor bug

Signed-off-by: Future-Outlier <[email protected]>

* upadte

Signed-off-by: Future-Outlier <[email protected]>

* add actor.LabelSelector

Signed-off-by: Future-Outlier <[email protected]>

* better query for additional endpoints, request URI (path + query)

Signed-off-by: Future-Outlier <[email protected]>

* Add comments

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: jinbum9958 <[email protected]>
Signed-off-by: Andrew Sy Kim <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Co-authored-by: Han-Ju Chen (Future-Outlier) <[email protected]>
Co-authored-by: Jinbum Kim <[email protected]>
Co-authored-by: Andrew Sy Kim <[email protected]>
Co-authored-by: Ryan O'Leary <[email protected]>
Co-authored-by: Claude Opus 4.6 <[email protected]>
Co-authored-by: Matt Boersma <[email protected]>
Co-authored-by: Jia-Wei Jiang <[email protected]>
Co-authored-by: Chia-Yi Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants