Skip to content

Disable the field alignment lint check #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewsykim merged 5 commits into from
Mar 11, 2026
Merged

Disable the field alignment lint check #4560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a820224
chore: disable govet fieldalignment lint
jinbum-kim Mar 4, 2026
4c5840c
chore: remove redundant //nolint:govet comments
jinbum-kim Mar 4, 2026
29d4673
chore: restore RayCronJobSpec/RayCronJob comments
jinbum-kim Mar 5, 2026
0163020
chore: restore RayCronJob comment
jinbum-kim Mar 10, 2026
f5a2bda
chore: regenerate artifacts for RayCronJob comment changes
jinbum-kim Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ linters:
gosec:
excludes:
- G601
govet:
enable:
- fieldalignment
lll:
line-length: 120
misspell:
Expand Down
2 changes: 1 addition & 1 deletion docs/reference/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ _Appears in:_




RayCronJob is the Schema for the raycronjobs API



Expand Down
2 changes: 1 addition & 1 deletion ray-operator/apis/ray/v1/raycronjob_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type RayCronJobStatus struct {
// +kubebuilder:resource:categories=all
// +kubebuilder:storageversion
//
//nolint:govet // RayCronJob is the Schema for the raycronjobs API
Copy link
Member

@andrewsykim andrewsykim Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the original comment // RayCronJob is the Schema for the raycronjobs API

Copy link
Contributor Author

@jinbum-kim jinbum-kim Mar 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore in here

// RayCronJob is the Schema for the raycronjobs API
type RayCronJob struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand Down
2 changes: 0 additions & 2 deletions ray-operator/apis/ray/v1/rayjob_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,6 @@ type RayJobStatusInfo struct {
}

// RayJobSpec defines the desired state of RayJob
//
//nolint:govet // Prevent reordering fields and removing comments
type RayJobSpec struct {
// ActiveDeadlineSeconds is the duration in seconds that the RayJob may be active before
// KubeRay actively tries to terminate the RayJob; value must be positive integer.
Expand Down
1 change: 0 additions & 1 deletion ray-operator/controllers/ray/rayjob_controller_unit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,6 @@ func TestEmitRayJobExecutionDuration(t *testing.T) {
rayJobUID := types.UID("test-job-uid")
mockTime := time.Now().Add(-60 * time.Second)

//nolint:govet // disable govet to keep the order of the struct fields
tests := []struct {
name string
originalRayJobStatus rayv1.RayJobStatus
Expand Down
2 changes: 2 additions & 0 deletions ray-operator/pkg/client/applyconfiguration/ray/v1/raycronjob.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading