Skip to content

Conversation

@Safenein
Copy link
Contributor

This pull request refactors the validation logic in the add_preset function within lua/reactive/state.lua to fix the deprecation warning (Neovim documentation).

Fixes #26.

@rasulomaroff
Copy link
Owner

Hi there, thank you for the fix.

What's the minimum neovim version that supports that updated signature?

@Safenein
Copy link
Contributor Author

Hi, it is deprecated in Neovim 0.11.

Do you need retro-compatibility?

@Safenein
Copy link
Contributor Author

Here it is.

@Safenein
Copy link
Contributor Author

Sorry, I misunderstood your question, the new signature is available since Neovim 0.10 (see NEWS).

I based the retro-compatibility patch by replicating something similar to mason-org/mason.nvim#1875.

Do you need any edits?

@rasulomaroff
Copy link
Owner

@Safenein No, not really. Thank you for your contribution!

Sorry, it took me a while to get back to this 😶

@rasulomaroff rasulomaroff merged commit 0588b5c into rasulomaroff:master Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WARNING vim.validate{<table>} is deprecated

2 participants