Setting `n` or `c` highlights causes `vim.ui.select` to not show options as of neovim 0.11.

[SlayerOfTheBad]

In NeoVim 0.11, when highlights are set for modes n or c, and vim.ui.select is called, the options for the selection are not show.

There might be more effected modes, but these are the ones in my configuration that cause issues.
From my testing, it seems to be caused by the vim.cmd.redraw() at highlight.lua:16 being called.

[rasulomaroff]

Hi there!

Could you please describe the situation or what you exactly do in order to get that error?

I'm using neovim 0.11 since its release and don't have any issues, but I don't have many plugins either. Wonder if that's somehow related to other UI plugins that utilize vim.ui.select functionality of neovim.

[SlayerOfTheBad]

Ah yes, sorry for not providing the full details. My setup is as follows:

neofetch output:

~ via 🌙 v5.4.7 via 🦀 v1.85.1 took 3s 
❯ neofetch
                   -`                    slayer@Slayer-Rig 
                  .o+`                   ----------------- 
                 `ooo/                   OS: Arch Linux 
                `+oooo:                  Kernel: 6.14.3-zen1-1-zen 
               `+oooooo:                 Uptime: 1 hour, 48 mins 
               -+oooooo+:                Packages: 1996 (pacman) 
             `/:-:++oooo+:               Shell: zsh 
            `/++++/+++++++:              WM: sway 
           `/++++++++++++++:             Terminal: kitty 
          `/+++ooooooooooooo/`           CPU: AMD Ryzen 9 7900X (24) @ 5.7GHz 
         ./ooosssso++osssssso+`          GPU: AMD ATI Radeon RX 7900 XT/7900 XTX/7900 GRE/7900M 
        .oossssso-````/ossssss+`         Memory: 6.60GiB / 31.06GiB 
       -osssssso.      :ssssssso.
      :osssssss/        osssso+++.                               
     /ossssssss/        +ssssooo/-                               
   `/ossssso+/:-        -:/+osssso+-
  `+sso+:-`                 `.-/+oso:
 `++:.                           `-/+/
 .`                                 `/

(The WM is not completely accurate, I'm actually running river, though I've also experienced this in Xfce)
For terminals, I have tried both kitty and foot, and for shells I've tried both zsh and bash.

nvim -V1 -v output:

~ via 🌙 v5.4.7 via 🦀 v1.85.1 took 1m23s 
❯ nvim -V1 -v
NVIM v0.11.0
Build type: RelWithDebInfo
LuaJIT 2.1.1741730670
Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions     -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security     -fstack-clash-protection -fcf-protection     -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/neovim/src=/usr/src/debug/neovim -flto=auto -O2 -g -flto=auto -fno-fat-lto-objects -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wvla -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -fsigned-char -fstack-protector-strong -Wno-conversion -fno-common -Wno-unused-result -Wimplicit-fallthrough -fdiagnostics-color=always  -DUNIT_TESTING -D_GNU_SOURCE -DINCLUDE_GENERATED_DECLARATIONS -DUTF8PROC_STATIC -I/usr/include/luajit-2.1 -I/usr/include -I/build/neovim/src/neovim/build/src/nvim/auto -I/build/neovim/src/neovim/build/include -I/build/neovim/src/neovim/build/cmake.config -I/build/neovim/src/neovim/src 

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

Minimal config:

local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not (vim.uv or vim.loop).fs_stat(lazypath) then
    vim.fn.system({
        "git",
        "clone",
        "--filter=blob:none",
        "https://github.com/folke/lazy.nvim.git",
        "--branch=stable", -- latest stable release
        lazypath,
    })
end
vim.opt.rtp:prepend(lazypath)

require("lazy").setup({
    spec = {
        {
            "rasulomaroff/reactive.nvim",
            config = function(_, _)
                local reactive = require("reactive")

                reactive.add_preset {
                    name = 'gruvbox',
                    modes = {
                        n = {
                            hl = {
                                ReactiveCursor = { bg = '#cbd5e1' },
                            },
                        },
                    },
                }
                reactive.setup { load = { 'gruvbox' } }
            end,
        }
    }
});

When I use this config, open nvim, and run :lua vim.ui.select({"OptionOne", "OptionTwo"}, {}, function(option) vim.print(option) end), I do not get a selection dialogue as I would expect.

I do get the Type number and <Enter> or click with the mouse (q or empty cancels): text, but am not shown the options.

The same occurs when I changes modes.n to modes.c, but not with modes.[{ 'i', 'niI' }] modes.i, modes.[{ 'v', 'V', '\x16' }], modes.[{ 's', 'S', '\x13' }], modes.[{ 'R', 'niR', 'niV' }], modes.R, or a more complicated modes.no setup.
It also occurs when modes.n.hl is changed for a modes.n.winhl config.
Long story short, it breaks with modes.c and modes.n, but not any other modes sub-settings I've tried.

I concluded it was being caused by the vim.cmd.redraw() call by a bunch of commenting out in a local version of reactive.nvim

[rasulomaroff]

Hey, thank you for your repro! That was very helpful and indeed, the reason for that is vim.cmd.redraw.

Previously, I also noticed that it (redraw command) was the cause for some other bugs as well.

Your repro can be reduced to just this:

vim.api.nvim_create_autocmd('ModeChanged', {
    callback = function() vim.cmd.redraw() end,
})

If you run neovim with just above autocmd and try to run your previously suggested command, which is :lua vim.ui.select({"OptionOne", "OptionTwo"}, {}, function(option) vim.print(option) end), then you're gonna see the same bug - no visible options.

Now, from here I'm not really sure if we can treat this as a reactive plugin bug. I believe this is a neovim issue, if it's considered to be the issue at all (maybe it's a feature or something logical). We should probably also ask/open the issue in the neovim repo.