drm/vc4: Fix potential null pointer read when disabling vblank #6151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vc4_disable_vblank assumed that vc4_encoder was always assigned, which isn't guaranteed. If it isn't assigned then disable the interrupt anyway as it's not connected. raspberrypi#6146 Fixes: 63c0bcc ("drm/vc4: Add option to call from crtc to encoder on vblank") Signed-off-by: Dave Stevenson <[email protected]>
popcornmix
approved these changes
May 7, 2024
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 9, 2024
See: raspberrypi/linux#6151 kernel: defconfigs: Add ILI9881 to rpi and bcm2709 defconfigs See: raspberrypi/linux#6025 kernel: configs: Enable BCACHEFS as a module See: raspberrypi/linux#6149 kernel: gpios: Adapt to the upstream persist_gpio_outputs change See: raspberrypi/linux#6150 kernel: dts: bcm2712: Drop snd_bcm2835 bootargs references from Pi5 See: raspberrypi/linux#6153 kernel: overlays: Add sc16is750-spi0
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 9, 2024
See: raspberrypi/linux#6151 kernel: defconfigs: Add ILI9881 to rpi and bcm2709 defconfigs See: raspberrypi/linux#6025 kernel: configs: Enable BCACHEFS as a module See: raspberrypi/linux#6149 kernel: gpios: Adapt to the upstream persist_gpio_outputs change See: raspberrypi/linux#6150 kernel: dts: bcm2712: Drop snd_bcm2835 bootargs references from Pi5 See: raspberrypi/linux#6153 kernel: overlays: Add sc16is750-spi0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vc4_disable_vblank assumed that vc4_encoder was always assigned, which isn't guaranteed.
If it isn't assigned then disable the interrupt anyway as it's not connected.
#6146
Fixes: 63c0bcc ("drm/vc4: Add option to call from crtc to encoder on vblank")