Skip to content

Fix up rotation support for panels #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelwell merged 4 commits into from
Apr 25, 2024
Merged

Fix up rotation support for panels #6113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d7d4ed
drm/panel: Add and initialise an orientation field to drm_panel from OF
6by9 Feb 1, 2022
7b4645a
Revert "drm/panel-simple: hack ignore orientation"
6by9 Apr 18, 2024
b44d092
Revert "drm/panel: simple: Remove custom handling of orientation"
6by9 Apr 18, 2024
769c64e
drm/panel-simple: Remove custom handling of orientation
6by9 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions drivers/gpu/drm/drm_connector.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2697,10 +2697,15 @@ int drm_connector_set_orientation_from_panel(
{
enum drm_panel_orientation orientation;

if (panel && panel->funcs && panel->funcs->get_orientation)
if (panel && panel->funcs && panel->funcs->get_orientation) {
orientation = panel->funcs->get_orientation(panel);
else
} else {
orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
if (panel) {
of_drm_get_panel_orientation(panel->dev->of_node,
&orientation);
}
}

return drm_connector_set_panel_orientation(connector, orientation);
}
Expand Down
8 changes: 0 additions & 8 deletions drivers/gpu/drm/panel/panel-simple.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,20 +430,12 @@ static int panel_simple_get_timings(struct drm_panel *panel,
return p->desc->num_timings;
}

static enum drm_panel_orientation panel_simple_get_orientation(struct drm_panel *panel)
{
//struct panel_simple *p = to_panel_simple(panel);

return DRM_MODE_PANEL_ORIENTATION_UNKNOWN;
}

static const struct drm_panel_funcs panel_simple_funcs = {
.disable = panel_simple_disable,
.unprepare = panel_simple_unprepare,
.prepare = panel_simple_prepare,
.enable = panel_simple_enable,
.get_modes = panel_simple_get_modes,
.get_orientation = panel_simple_get_orientation,
.get_timings = panel_simple_get_timings,
};

Expand Down