drivers: staging: bcm2835-isp: Respect caller's stride value #5960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM! |
Contributor
|
I thought we had this anyway, but I guess not. Looks fine, although it does give userspace an easy way to allocate masses of memory by artificially inflating the stride. Then again VIDIOC_CREATE_BUFS allows you to do that anyway. |
popcornmix
force-pushed
the
rpi-6.6.y
branch
2 times, most recently
from
6036a96 to
aa41065
Compare
vanlayag
approved these changes
Feb 28, 2024
Collaborator
|
@davidplowman this needs a rebase before merging. |
davidplowman
force-pushed
the
isp-stride-fix
branch
from
b9a98c8 to
ae83350
Compare
The stride value reported for output image buffers should be at least as large as any value that was passed in by the caller (subject to correct alignment for the pixel format). If the value is zero (meaning no value was passed), or is too small, the minimum acceptable value will be substituted. Signed-off-by: David Plowman <[email protected]>
davidplowman
force-pushed
the
isp-stride-fix
branch
from
ae83350 to
b124e56
Compare
Contributor
Author
|
Sorry, failed to spot that this wanted a rebase. Hopefully all good now...! |
Contributor
|
Still LGTM |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 24, 2024
See: raspberrypi/linux#6180 kernel: drivers: staging: bcm2835-isp: Respect caller's stride value See: raspberrypi/linux#5960 kernel: drivers: pcie-brcmstb: add best-effort workaround for QoS bug on bcm2712 See: raspberrypi/linux#6183 kernel: ARM: dts: Fix camera sync parameters See: raspberrypi/linux#6184 kernel: Add association between DRM panels and backlight where defined See: raspberrypi/linux#6177
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 24, 2024
See: raspberrypi/linux#6180 kernel: drivers: staging: bcm2835-isp: Respect caller's stride value See: raspberrypi/linux#5960 kernel: drivers: pcie-brcmstb: add best-effort workaround for QoS bug on bcm2712 See: raspberrypi/linux#6183 kernel: ARM: dts: Fix camera sync parameters See: raspberrypi/linux#6184 kernel: Add association between DRM panels and backlight where defined See: raspberrypi/linux#6177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stride value reported for output image buffers should be at least as large as any value that was passed in by the caller (subject to correct alignment for the pixel format). If the value is zero (meaning no value was passed), or is too small, the minimum acceptable value will be substituted.