Add RMM patch to update include paths and allocation interface#110
Merged
hcho3 merged 4 commits intorapidsai:mainfrom Nov 25, 2025
Merged
Add RMM patch to update include paths and allocation interface#110hcho3 merged 4 commits intorapidsai:mainfrom
hcho3 merged 4 commits intorapidsai:mainfrom
Conversation
trivialfis
approved these changes
Nov 21, 2025
Member
trivialfis
left a comment
trivialfis
left a comment
There was a problem hiding this comment.
The patch looks good to me.
Merged
|
The windows job is failing as it's picking up CCCL 3.1.2, not CCCL 3.1.3 |
Member
|
That's probably because CCCL 3.1.3 hadn't been packaged yet. It now is: conda-forge/cccl-feedstock#41 |
Author
|
@jakirkham @hcho3 @trivialfis CI is now passing. Should we merge this with the R package disabled, so that we can unblock cuML's testing? |
|
Merging this for now to unblock cuML testing. I created the follow-up issue at #111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes xgboost compatible with changes in RMM 25.12 for headers and allocation interfaces.
This also rebuilds with CCCL 3.1.3 (in progress). Depends on NVIDIA/cccl#6727 and rapidsai/rapids-cmake#944, followed by a fresh nightly build of RMM 25.12.