-
Notifications
You must be signed in to change notification settings - Fork 4
Presto: Separate Hive configs for Coordinator & Worker #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simoneves
wants to merge
5
commits into
main
Choose a base branch
from
seves/HERC-139_split_hive_config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e52b5cc
Split files
simoneves 1714590
Map split files
simoneves 6e8dc10
Add default Parquet read options to Worker Hive properties
simoneves 84b10bd
Add comments on Parquet read parameters
simoneves 66ac846
Merge branch 'main' into seves/HERC-139_split_hive_config
simoneves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
22 changes: 1 addition & 21 deletions
22
presto/docker/config/template/etc_common/catalog/hive.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1 @@ | ||
| # Select the connector implementation. "hive-hadoop2" uses the Hive connector | ||
| # backed by Hadoop 2.x libraries which is the default for Presto's Hive support. | ||
| connector.name=hive-hadoop2 | ||
|
|
||
| # Configure the metastore implementation. "file" enables a simple file-based | ||
| # metastore suitable for local testing without an external Hive Metastore (HMS). | ||
| # See https://prestodb.io/docs/current/installation/deployment.html#configuring-a-file-based-metastore for more details. | ||
| hive.metastore=file | ||
| # Root directory where the file-based metastore stores table and partition | ||
| # metadata. This path is inside the container volume so state persists across | ||
| # server restarts during tests. | ||
| hive.metastore.catalog.dir=file:/var/lib/presto/data/hive/metastore | ||
| # Allow DROP TABLE statements. Enabled to make smoke/perf tests able to reset | ||
| # state and clean up artifacts without manual intervention. | ||
| hive.allow-drop-table=true | ||
|
|
||
| # Control whether Presto can split files for parallel reads. Disable when the | ||
| # file compression/format isn't splittable to avoid read failures. TPCH Parquet | ||
| # test data commonly uses SNAPPY compression that isn't splittable at the file | ||
| # level here, hence this must be false. | ||
| hive.file-splittable=false | ||
| # This file will be overridden by a coordinator or worker specific configuration file. |
21 changes: 21 additions & 0 deletions
21
presto/docker/config/template/etc_coordinator/catalog/hive.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Select the connector implementation. "hive-hadoop2" uses the Hive connector | ||
| # backed by Hadoop 2.x libraries which is the default for Presto's Hive support. | ||
| connector.name=hive-hadoop2 | ||
|
|
||
| # Configure the metastore implementation. "file" enables a simple file-based | ||
| # metastore suitable for local testing without an external Hive Metastore (HMS). | ||
| # See https://prestodb.io/docs/current/installation/deployment.html#configuring-a-file-based-metastore for more details. | ||
| hive.metastore=file | ||
| # Root directory where the file-based metastore stores table and partition | ||
| # metadata. This path is inside the container volume so state persists across | ||
| # server restarts during tests. | ||
| hive.metastore.catalog.dir=file:/var/lib/presto/data/hive/metastore | ||
| # Allow DROP TABLE statements. Enabled to make smoke/perf tests able to reset | ||
| # state and clean up artifacts without manual intervention. | ||
| hive.allow-drop-table=true | ||
|
|
||
| # Control whether Presto can split files for parallel reads. Disable when the | ||
| # file compression/format isn't splittable to avoid read failures. TPCH Parquet | ||
| # test data commonly uses SNAPPY compression that isn't splittable at the file | ||
| # level here, hence this must be false. | ||
| hive.file-splittable=false |
27 changes: 27 additions & 0 deletions
27
presto/docker/config/template/etc_worker/catalog/hive.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Select the connector implementation. "hive-hadoop2" uses the Hive connector | ||
| # backed by Hadoop 2.x libraries which is the default for Presto's Hive support. | ||
| connector.name=hive-hadoop2 | ||
|
|
||
| # Configure the metastore implementation. "file" enables a simple file-based | ||
| # metastore suitable for local testing without an external Hive Metastore (HMS). | ||
| # See https://prestodb.io/docs/current/installation/deployment.html#configuring-a-file-based-metastore for more details. | ||
| hive.metastore=file | ||
| # Root directory where the file-based metastore stores table and partition | ||
| # metadata. This path is inside the container volume so state persists across | ||
| # server restarts during tests. | ||
| hive.metastore.catalog.dir=file:/var/lib/presto/data/hive/metastore | ||
| # Allow DROP TABLE statements. Enabled to make smoke/perf tests able to reset | ||
| # state and clean up artifacts without manual intervention. | ||
| hive.allow-drop-table=true | ||
|
|
||
| # Control whether Presto can split files for parallel reads. Disable when the | ||
| # file compression/format isn't splittable to avoid read failures. TPCH Parquet | ||
| # test data commonly uses SNAPPY compression that isn't splittable at the file | ||
| # level here, hence this must be false. | ||
| hive.file-splittable=false | ||
|
|
||
| # Parquet read options | ||
| # Limit (in bytes) on total number of bytes to be returned per read, or 0 if there is no limit | ||
| parquet.reader.chunk-read-limit=0 | ||
| # Limit (in bytes) on the amount of memory used for reading and decompressing data or 0 if there is no limit | ||
| parquet.reader.pass-read-limit=0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the updates be in docker-compose.common.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can't be because configs are now per-variant