Skip to content

Conversation

@KyleFromNVIDIA
Copy link
Member

@KyleFromNVIDIA KyleFromNVIDIA added the improvement Improves an existing functionality label Oct 21, 2025
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners October 21, 2025 18:45
@KyleFromNVIDIA KyleFromNVIDIA added the non-breaking Introduces a non-breaking change label Oct 21, 2025
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners October 21, 2025 18:45
@KyleFromNVIDIA KyleFromNVIDIA requested a review from bdice October 21, 2025 18:45
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some files that have the wrong (Apache 2.0) license, I left requests for changes. The project is BSD-3-Clause unlike most other RAPIDS projects because we want a license matching that of the UCX project.

There are also a few files, namely RAPIDS.cmake, rapids_config.cmake and get_rmm.cmake, that are Apache 2.0 license because they're copies from other projects, can we relicense them to BSD-3-Clause here? This doesn't have necessarily to be done in this PR, but it's a question we should answer because when we upstream UCXX to the UCX repository, then we may need to remove/rewrite those files if the Apache 2.0 license is incompatible.

@KyleFromNVIDIA
Copy link
Member Author

I left the files from other projects as Apache-2.0 because I don't know if they've received external contributions that would make us unable to relicense them. I'll have to do some digging to find that out.

I'll relicense the ones that were already part of this project.

@KyleFromNVIDIA
Copy link
Member Author

I wrote _version.py myself, so I know that one is fine to relicense. Still investigating the others.

@KyleFromNVIDIA
Copy link
Member Author

I've been informed by @robertmaynard that all of the files are safe to relicense.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks so much Kyle!

@KyleFromNVIDIA
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 123b2ec into rapidsai:main Oct 27, 2025
248 of 254 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants