Add ucxx::Request callback to constructor arguments#194
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-0.39from Jun 28, 2024
Merged
Add ucxx::Request callback to constructor arguments#194rapids-bot[bot] merged 8 commits intorapidsai:branch-0.39from
ucxx::Request callback to constructor arguments#194rapids-bot[bot] merged 8 commits intorapidsai:branch-0.39from
Conversation
pentschev
added
improvement
wence-
approved these changes
Jun 28, 2024
Co-authored-by: Lawrence Mitchell <[email protected]>
Member
Author
|
Thanks @wence- for reviewing! |
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callbacks had to be assigned during the constructor because the member attributes are part of the base class. Now the base class exposes those arguments via the constructor and they can then be passed directly to the base class' constructor.