Add ucxx::MemoryHandle and ucxx::RemoteKey C++ classes#190
Merged
rapids-bot[bot] merged 11 commits intorapidsai:branch-0.37from Feb 20, 2024
Merged
Add ucxx::MemoryHandle and ucxx::RemoteKey C++ classes#190rapids-bot[bot] merged 11 commits intorapidsai:branch-0.37from
ucxx::MemoryHandle and ucxx::RemoteKey C++ classes#190rapids-bot[bot] merged 11 commits intorapidsai:branch-0.37from
Conversation
pentschev
added
feature request
wence-
requested changes
Feb 14, 2024
Contributor
wence-
left a comment
wence-
left a comment
There was a problem hiding this comment.
Mostly some requests for clarifications in docstrings. Overall I think this looks good.
Co-authored-by: Lawrence Mitchell <[email protected]>
wence-
approved these changes
Feb 16, 2024
Contributor
wence-
left a comment
wence-
left a comment
There was a problem hiding this comment.
Just one outstanding question about the required size constraints on a user-provided buffer, but again, I think (if it needs it at all) this is just a doc clarification.
Thanks!
Member
Author
|
Thanks @wence- for the thorough review! |
Member
Author
|
/merge |
bdice
approved these changes
Feb 20, 2024
robertmaynard
approved these changes
Feb 20, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
This PR adds support for RMA over UCP protocols, adding interfaces for the following functions: `ucp_get_nbx`, `ucp_put_nbx`, `ucp_ep_flush_nbx` and `ucp_worker_flush_nbx`. The implementation follows the same pattern use for all `ucxx::Request` operations. Blocked waiting for #190 . Authors: - Michael Demoret (https://github.com/mdemoret-nv) - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Peter Andreas Entschev (https://github.com/pentschev) URL: #166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ucxx::MemoryHandleanducxx::RemoteKeyC++ classes, wrapping UCP memory handles (ucp_mem_h) and remote keys (ucp_rkey_h), respectively.These new classes are required to provide basic support for RMA (Remote Memory Access) operations being implemented in #166 .