Add compiler('cuda') to ucxx builds.#108
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-0.35from Oct 21, 2023
Merged
Add compiler('cuda') to ucxx builds.#108rapids-bot[bot] merged 3 commits intorapidsai:branch-0.35from
rapids-bot[bot] merged 3 commits intorapidsai:branch-0.35from
Conversation
…to-ucxx-conda-builds
bdice
added
bug
pentschev
approved these changes
Oct 20, 2023
Member
|
/merge |
jakirkham
approved these changes
Oct 20, 2023
ajschmidt8
approved these changes
Oct 21, 2023
Member
|
Thanks all! 🙏 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Some improvements / modernizations for the package and dependencies. Depends on #108. Authors: - Bradley Dice (https://github.com/bdice) - https://github.com/jakirkham - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: #109
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
`ucxx`'s CUDA compiler dependency added a `cuda-version` constraint at runtime that meant packages could only be installed with the same CUDA version `ucxx` was built with or newer. As a result CUDA 12.2 builds of `ucxx` required that CUDA 12.2+ would be used at runtime However as we use [CUDA Compatibility]( https://docs.nvidia.com/deploy/cuda-compatibility/index.html ) in RAPIDS, we know that even if we built with CUDA 12.2, we can still use packages for other CUDA 12.x This was largely handled for other dependencies as part of PR ( #161 ). However this wasn't handled for `ucxx`, which was likely in part as it was handling the CUDA compiler dependency differently from the other packages here. More history about `ucxx`'s CUDA compiler dependency in PR: #108 This change aligns how CUDA compiler is handled across packages to make this more consistent. Also it ignores the CUDA compiler constraints added at runtime. In all cases the packages handle this themselves by requiring `cuda-version` (properly constrained) and when CUDA 11 is concerned they add `cudatoolkit` Thus this change should fix CI issues that were seen due to this overly constrained `cuda-version` by relaxing that constraint Authors: - https://github.com/jakirkham Approvers: - Bradley Dice (https://github.com/bdice) - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: #195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some build failures have been occurring on CUDA 12. This PR fixes the builds by adding a build dependency on
compiler('cuda')for CUDA 12 in the ucxx package.Also includes changes from #107.