Skip to content

add package manager proxy cache for build jobs#253

Merged
msarahan merged 4 commits intonvks-runnersfrom
proxy-cache
Feb 5, 2025
Merged

add package manager proxy cache for build jobs#253
msarahan merged 4 commits intonvks-runnersfrom
proxy-cache

Conversation

@msarahan
Copy link
Copy Markdown
Contributor

@msarahan msarahan commented Oct 18, 2024

@msarahan msarahan requested a review from a team as a code owner October 18, 2024 16:42
@msarahan msarahan requested a review from AyodeAwe October 18, 2024 16:42
@ajschmidt8
Copy link
Copy Markdown
Member

Seeing these warnings in the downstream workflows.

image

Fortunately these arguments default to true anyway, so it should have no effect on this initial testing. But we'll want to fix it nonetheless

@msarahan msarahan changed the base branch from branch-24.12 to branch-23.04 January 30, 2025 15:50
@msarahan msarahan changed the base branch from branch-23.04 to branch-25.04 January 30, 2025 15:50
@msarahan
Copy link
Copy Markdown
Contributor Author

msarahan commented Jan 30, 2025

Rebased to 25.02 and removed the pip/conda specifiers that @ajschmidt8 pointed out.

@msarahan msarahan changed the base branch from branch-25.04 to branch-25.02 January 30, 2025 15:52
@ajschmidt8
Copy link
Copy Markdown
Member

Can we get some new downstream tests to ensure everything is working as expected?

@msarahan
Copy link
Copy Markdown
Contributor Author

msarahan commented Jan 30, 2025

Looks like it is setting the env vars as expected. I don't know that I can comment on any performance improvements, but the work here at least looks non-disruptive.

https://github.com/rapidsai/rmm/actions/runs/13057200836/job/36431299581?pr=1801

@bdice
Copy link
Copy Markdown
Contributor

bdice commented Jan 31, 2025

FYI, I merged the upstream so the PR diff would no longer show CUDA 12.8 related changes. Nothing functional should have changed.

@msarahan msarahan changed the base branch from branch-25.02 to branch-25.04 January 31, 2025 17:49
@msarahan msarahan changed the base branch from branch-25.04 to nvks-runners January 31, 2025 17:59
Comment thread .github/workflows/conda-cpp-tests.yaml
@ajschmidt8
Copy link
Copy Markdown
Member

Looks like it is setting the env vars as expected. I don't know that I can comment on any performance improvements, but the work here at least looks non-disruptive.

https://github.com/rapidsai/rmm/actions/runs/13057200836/job/36431299581?pr=1801

There's a Slack thread floating around where we identified that there may not be any particular performance enhancements since conda/PyPI could already be using CDNs. However, workflows should be more reliable against network issues by using the proxy.

@msarahan msarahan requested a review from bdice February 4, 2025 16:01
@msarahan
Copy link
Copy Markdown
Contributor Author

msarahan commented Feb 5, 2025

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants