Skip to content

Upload wheels to public anaconda index#154

Merged
AyodeAwe merged 3 commits intorapidsai:branch-23.12from
AyodeAwe:add_publish_tkn
Nov 15, 2023
Merged

Upload wheels to public anaconda index#154
AyodeAwe merged 3 commits intorapidsai:branch-23.12from
AyodeAwe:add_publish_tkn

Conversation

@AyodeAwe
Copy link
Copy Markdown
Contributor

@AyodeAwe AyodeAwe commented Nov 13, 2023

PR updates the wheels-publish step to upload wheels to anaconda instead of the existing internal PyPI.

Cross-references:

@AyodeAwe AyodeAwe added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 13, 2023
Copy link
Copy Markdown
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we have to propagate the token to all repos that upload wheels? Have we done that yet?

@AyodeAwe AyodeAwe marked this pull request as ready for review November 13, 2023 23:04
@vyasr
Copy link
Copy Markdown
Contributor

vyasr commented Nov 13, 2023

While we're at it, we should also update https://github.com/rapidsai/shared-workflows/blob/branch-23.12/.github/workflows/build-in-devcontainer.yaml#L96 so that devcontainer builds look in the new index.

@AyodeAwe
Copy link
Copy Markdown
Contributor Author

Will we have to propagate the token to all repos that upload wheels? Have we done that yet?

Good catch. Looking into that now

@AyodeAwe
Copy link
Copy Markdown
Contributor Author

Will we have to propagate the token to all repos that upload wheels? Have we done that yet?

Yep. They are propagated to all repos that upload wheels.

@AyodeAwe AyodeAwe merged commit d9cf6f0 into rapidsai:branch-23.12 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants