Use CUDA 13.2 in Conda, Devcontainers, Spark, GHA, etc.#2365
Use CUDA 13.2 in Conda, Devcontainers, Spark, GHA, etc.#2365jakirkham wants to merge 4 commits intorapidsai:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis PR updates the project's CUDA version from 13.1 to 13.2 across devcontainer configurations, conda environment specifications, GitHub Actions workflows, dependency matrices, and documentation files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 39: Docs are inconsistent: the conda install line was changed to use
cuda-version=13.2 but the build-from-source example still references the old
file name all_cuda-131_arch-$(uname -m).yaml; update the build-from-source
example to the matching CUDA 13.2 name (e.g., rename all_cuda-131_arch-$(uname
-m).yaml to all_cuda-132_arch-$(uname -m).yaml) and verify any other occurrences
of "131" or "131" naming are replaced so the README consistently references CUDA
13.2.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c45f7645-7a69-4bb4-a106-1e6d869add99
📒 Files selected for processing (7)
.devcontainer/cuda13.2-conda/devcontainer.json.devcontainer/cuda13.2-pip/devcontainer.json.github/workflows/pr.yamlREADME.mdconda/environments/all_cuda-132_arch-aarch64.yamlconda/environments/all_cuda-132_arch-x86_64.yamldependencies.yaml
|
|
||
| ```bash | ||
| conda install -c rapidsai -c conda-forge rmm cuda-version=13.1 | ||
| conda install -c rapidsai -c conda-forge rmm cuda-version=13.2 |
There was a problem hiding this comment.
Update the source-build env file example to CUDA 13.2 naming.
The command at Line 39 is updated, but the build-from-source example still references all_cuda-131_arch-$(uname -m).yaml (Line 91). That leaves docs inconsistent and can break setup.
Suggested doc fix
- $ conda env create --name rmm_dev --file conda/environments/all_cuda-131_arch-$(uname -m).yaml
+ $ conda env create --name rmm_dev --file conda/environments/all_cuda-132_arch-$(uname -m).yaml📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| conda install -c rapidsai -c conda-forge rmm cuda-version=13.2 | |
| $ conda env create --name rmm_dev --file conda/environments/all_cuda-132_arch-$(uname -m).yaml |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 39, Docs are inconsistent: the conda install line was
changed to use cuda-version=13.2 but the build-from-source example still
references the old file name all_cuda-131_arch-$(uname -m).yaml; update the
build-from-source example to the matching CUDA 13.2 name (e.g., rename
all_cuda-131_arch-$(uname -m).yaml to all_cuda-132_arch-$(uname -m).yaml) and
verify any other occurrences of "131" or "131" naming are replaced so the README
consistently references CUDA 13.2.
There was a problem hiding this comment.
Good catch! This is only in the README. AFAICT nowhere else
Will follow up in a bit
There was a problem hiding this comment.
🧩 Analysis chain
Let me quickly verify there are no other occurrences of the old 131 CUDA naming in the repo.
🏁 Script executed:
#!/bin/bash
rg -n "cuda.?13[._-]?1|all_cuda-131|cuda-131|cuda13\.1|CUDA 13\.1" --type-add 'yaml:*.yaml' -t yaml -t markdown -t json
Length of output: 432
@jakirkham, confirmed! The search results back you up:
README.mdline 91 — the only actionable stale reference (the one flagged in my review comment).CHANGELOG.mdlines 8, 97, 98 — historical entries documenting when CUDA 13.1 support was added/fixed; those are correct as-is and shouldn't be touched.
So the fix is just the one-liner in README.md:
- $ conda env create --name rmm_dev --file conda/environments/all_cuda-131_arch-$(uname -m).yaml
+ $ conda env create --name rmm_dev --file conda/environments/all_cuda-132_arch-$(uname -m).yaml🧠 Learnings used
Learnt from: jameslamb
Repo: rapidsai/rmm PR: 2270
File: ci/test_wheel_integrations.sh:47-48
Timestamp: 2026-03-04T20:02:46.087Z
Learning: In rapidsai/rmm (and likely other RAPIDS projects), the CUDA version gate in `ci/test_wheel_integrations.sh` for PyTorch tests is intentionally broad (e.g., all CUDA 12.x and 13.0). It relies on `rapids-dependency-file-generator` to fail loudly when no matching matrix entry exists in `dependencies.yaml` for unsupported CUDA versions. Do not suggest tightening the shell gate to enumerate specific supported versions, as that would duplicate the version list unnecessarily.
Learnt from: jameslamb
Repo: rapidsai/rmm PR: 2270
File: dependencies.yaml:457-480
Timestamp: 2026-03-04T00:37:06.930Z
Learning: In rapidsai/rmm PR `#2270`, the `depends_on_pytorch` dependency in `dependencies.yaml` pins `torch==2.4.0+cu124` for the CUDA 12.2 + `dependencies: "oldest"` matrix. This version does not have wheels for Python 3.13 or 3.14 on the cu124 index (https://download.pytorch.org/whl/cu124). This is intentionally left as-is because the current CI matrix does not exercise that combination and the nightly matrix does not run integration jobs. A missing wheel for that combination will produce a loud install error if the matrix ever includes Python 3.13/3.14 with CUDA 12.2 oldest dependencies.
|
/ok to test |
Addressing issue:
Description
Use CUDA 13.2 throughout different build and test environments.