Explicitly mark RMM headers with RMM_EXPORT#1654
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-24.10from Aug 22, 2024
Merged
Conversation
robertmaynard
added
bug
jameslamb
approved these changes
Aug 20, 2024
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks! Changes make sense to me based on our offline conversations.
harrism
changed the title
RMM_EXPORTRMM_EXPORT
harrism
reviewed
Aug 21, 2024
3 tasks
wence-
reviewed
Aug 21, 2024
| */ | ||
|
|
||
| namespace rmm::mr { | ||
| namespace RMM_EXPORT rmm { |
Contributor
There was a problem hiding this comment.
This now means that the existing RMM_EXPORT on get_map in this file could be removed, IIUC. However, I suspect we should keep it (see also #1653) so that if we ever decide to tighten up the export list we don't lose that correctness.
robertmaynard
force-pushed
the
bug/explicitly_mark_exception_types_with_export_vis
branch
from
406a1eb to
8df2207
Compare
3 tasks
harrism
approved these changes
Aug 21, 2024
robertmaynard
force-pushed
the
bug/explicitly_mark_exception_types_with_export_vis
branch
from
eba260d to
870632a
Compare
wence-
reviewed
Aug 22, 2024
Contributor
Author
|
/merge |
Contributor
|
Thanks @robertmaynard! |
robertmaynard
deleted the
bug/explicitly_mark_exception_types_with_export_vis
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1652
Checklist