ensure update-version.sh preserves alpha specs#1572
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-24.08from May 30, 2024
jameslamb:more-rbb
Merged
ensure update-version.sh preserves alpha specs#1572rapids-bot[bot] merged 1 commit intorapidsai:branch-24.08from jameslamb:more-rbb
rapids-bot[bot] merged 1 commit intorapidsai:branch-24.08from
jameslamb:more-rbb
Conversation
KyleFromNVIDIA
approved these changes
May 29, 2024
bdice
approved these changes
May 30, 2024
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#31
Follow-up to #1502
update-version.shdoes not remove alpha specs like,>=0.0.0a0inpyproject.tomland conda environment filesrapids-build-backendversions independencies.yamlChecklist
Notes for Reviewers
Shouldn't this also be adding a test on the
__git_commit__and__version__constants?I'd said previously that I didn't include that in #1502, but looks like I actually did:
rmm/python/rmm/rmm/tests/test_version.py
Line 18 in 15c0466