Skip to content

target branch-24.04 for GitHub Actions workflows#1468

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.04from
jameslamb:gha-cuda-12.2
Feb 20, 2024
Merged

target branch-24.04 for GitHub Actions workflows#1468
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.04from
jameslamb:gha-cuda-12.2

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 15, 2024

Description

Follow-up to #1419

For all GitHub Actions configs, replaces uses of the test-cuda-12.2 branch on shared-workflows
with branch-24.04, now that rapidsai/shared-workflows#166 has been merged.

Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

(created with rapids-reviser)

@jameslamb jameslamb added non-breaking Non-breaking change DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function and removed DO NOT MERGE Hold off on merging; see PR for details labels Feb 15, 2024
@jameslamb jameslamb marked this pull request as ready for review February 15, 2024 20:09
@jameslamb jameslamb requested a review from a team as a code owner February 15, 2024 20:09
@jameslamb jameslamb requested a review from jakirkham February 15, 2024 21:10
@jameslamb
Copy link
Member Author

The (CUDA 11.4.3, centos7, amd64, Python 3.9, v100, latest driver) tests failed like this:

  ./resource_spec.json
Insufficient resources for test CALLBACK_MR_TEST:

  Test requested resources of type 'gpus' in the following amounts:
    5 slots
  but only the following units were available:
    '0': 0 slots

(build link)

That looks like the type of thing that might be resolvable by a re-run. I kicked this off along with 12+ other PRs all at the same time... that might have hit the CI runners too hard too fast.

@jakirkham
Copy link
Member

jakirkham commented Feb 15, 2024

Thanks James! 🙏

Sounds good. Restarted the failing job. Let's see how that goes

Edit: Restarted again

@jameslamb
Copy link
Member Author

🎉 all passing!

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 76bd29d into rapidsai:branch-24.04 Feb 20, 2024
@jameslamb jameslamb deleted the gha-cuda-12.2 branch February 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants