Skip to content

Disable NVBench CUPTI support by default. #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Dec 12, 2023
Merged

Disable NVBench CUPTI support by default. #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6932e00
Disable NVBench CUPTI support by default.
bdice Dec 12, 2023
3a006fd
Remove extra calls to disable CUPTI in tests.
bdice Dec 12, 2023
14c4ea8
Add note to docs.
bdice Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions rapids-cmake/cpm/nvbench.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ across all RAPIDS projects.
Will build nvbench statically. No local searching for a previously
built version will occur.

.. versionchanged:: v24.02.00

NVBench_ENABLE_CUPTI is set to OFF by default.

Result Targets
^^^^^^^^^^^^^^
nvbench::nvbench target will be created
Expand Down Expand Up @@ -93,8 +97,11 @@ function(rapids_cpm_nvbench)
GIT_SHALLOW ${shallow}
PATCH_COMMAND ${patch_command}
EXCLUDE_FROM_ALL ${exclude}
OPTIONS "NVBench_ENABLE_NVML ${nvbench_with_nvml}" "NVBench_ENABLE_EXAMPLES OFF"
"NVBench_ENABLE_TESTING OFF" "NVBench_ENABLE_INSTALL_RULES ${to_install}"
OPTIONS "NVBench_ENABLE_NVML ${nvbench_with_nvml}"
"NVBench_ENABLE_CUPTI OFF"
"NVBench_ENABLE_EXAMPLES OFF"
"NVBench_ENABLE_TESTING OFF"
"NVBench_ENABLE_INSTALL_RULES ${to_install}"
"BUILD_SHARED_LIBS ${build_shared}")

include("${rapids-cmake-dir}/cpm/detail/display_patch_status.cmake")
Expand Down
1 change: 0 additions & 1 deletion testing/cpm/cpm_nvbench-conda-fmt.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ rapids_cuda_set_architectures(RAPIDS)

# Force shared libs so that nvbench doesn't have a chance to use a static fmt
set(BUILD_SHARED_LIBS ON)
set(NVBench_ENABLE_CUPTI OFF)
rapids_cpm_init()
rapids_cpm_rmm()
rapids_cpm_nvbench()
Expand Down
1 change: 0 additions & 1 deletion testing/cpm/cpm_nvbench-conda.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ set(ENV{CONDA_BUILD} "1")
set(ENV{BUILD_PREFIX} "/usr/local/build_prefix")
set(ENV{PREFIX} "/opt/local/prefix")
set(ENV{CONDA_PREFIX} "/opt/conda/prefix")
set(NVBench_ENABLE_CUPTI OFF)
rapids_cpm_init()
rapids_cpm_nvbench()

Expand Down