Automatically figure out where to write GIT_COMMIT#30
Merged
KyleFromNVIDIA merged 6 commits intorapidsai:mainfrom May 15, 2024
Merged
Automatically figure out where to write GIT_COMMIT#30KyleFromNVIDIA merged 6 commits intorapidsai:mainfrom
KyleFromNVIDIA merged 6 commits intorapidsai:mainfrom
Conversation
In most cases, we will want to put GIT_COMMIT in a directory with the same name as the project (with hyphens replaced by underscores.) Put GIT_COMMIT there by default. Also rename _edit_git_commit() to _write_git_commit(), and don't create a backup file with the old GIT_COMMIT.
jameslamb
approved these changes
May 9, 2024
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks! I agree with the renaming. Changes and tests all look good to me.
I left 2 small suggestions for your consideration, but approving so if you agree to both of them you don't need to wait on another review from me.
vyasr
reviewed
May 9, 2024
vyasr
approved these changes
May 14, 2024
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jun 12, 2024
…build-backend configuration (#1582) Contributes to rapidsai/build-planning#31 Contributes to rapidsai/dependency-file-generator#89 #1502 was one of the first `rapids-build-backend` PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `rmm` up with those changes: * consolidates version-handling in `ci/build_cpp.sh` * removes `commit-file` configuration in `pyproject.toml` - *as of rapidsai/rapids-build-backend#30, this is no longer necessary if the project's top-level directory is `{project_name}.replace("-", "_")* - *and anyway, it was changed from `commit-file` to `commit-files` in that PR, so `commit-file` was being silently ignored here* * uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1582
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jun 12, 2024
…build-backend configuration (#15980) Contributes to rapidsai/build-planning#31 Contributes to rapidsai/dependency-file-generator#89 #15245 was one of the first `rapids-build-backend` PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `cudf` up with those changes: * consolidates version-handling in `ci/build_cpp.sh` * removes `commit-file` configuration in `pyproject.toml` - *as of rapidsai/rapids-build-backend#30, this is no longer necessary if the project's top-level directory is `{project_name}.replace("-", "_")* - *and anyway, it was changed from `commit-file` to `commit-files` in that PR, so `commit-file` was being silently ignored here* * uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: #15980
copy-pr-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jun 17, 2024
…build-backend configuration (#1582) Contributes to rapidsai/build-planning#31 Contributes to rapidsai/dependency-file-generator#89 #1502 was one of the first `rapids-build-backend` PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `rmm` up with those changes: * consolidates version-handling in `ci/build_cpp.sh` * removes `commit-file` configuration in `pyproject.toml` - *as of rapidsai/rapids-build-backend#30, this is no longer necessary if the project's top-level directory is `{project_name}.replace("-", "_")* - *and anyway, it was changed from `commit-file` to `commit-files` in that PR, so `commit-file` was being silently ignored here* * uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most cases, we will want to put GIT_COMMIT in a directory with the same name as the project (with hyphens replaced by underscores.) Put GIT_COMMIT there by default. Also rename _edit_git_commit() to _write_git_commit(), and don't create a backup file with the old GIT_COMMIT.