Change --config-setting to --config-settings#2342
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.08from Jun 4, 2024
Merged
Change --config-setting to --config-settings#2342rapids-bot[bot] merged 2 commits intorapidsai:branch-24.08from
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.08from
Conversation
pip install uses --config-settings as its argument.
jameslamb
approved these changes
May 24, 2024
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks!
I think it'd be helpful to link to the context for why we're doing this, so anyone else reviewing it (or finding it from search in the future) understands the purpose.
I'll add that here: rapidsai/cuml#5804 (comment)
KyleFromNVIDIA
added
bug
Member
|
/merge |
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
pip install uses --config-settings as its argument. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - James Lamb (https://github.com/jameslamb) Approvers: - James Lamb (https://github.com/jameslamb) URL: rapidsai#2342
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip install uses --config-settings as its argument.