Skip to content

Enable warnings as errors for Python tests#2288

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.06from
mroeschke:tst/wae
May 8, 2024
Merged

Enable warnings as errors for Python tests#2288
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.06from
mroeschke:tst/wae

Conversation

@mroeschke
Copy link
Copy Markdown
Contributor

As part of rapidsai/build-planning#26, warnings in Python tests will be converted to test failures

ignore:Unknown pytest.mark.ucx:PytestUnknownMarkWarning could be removed once #2281 is merged cc @jameslamb

@jameslamb
Copy link
Copy Markdown
Member

Thanks for the @.

I didn't even think about how this work you're doing would have caught the thing I just happened to notice in logs that led to #2281... nice!!

@rapidsai/raft-python-codeowners #2281 is small and I think non-controversial, it's ready for review.

@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 6, 2024
Copy link
Copy Markdown
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented May 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4c1bf03 into rapidsai:branch-24.06 May 8, 2024
@mroeschke mroeschke deleted the tst/wae branch May 8, 2024 16:33
abc99lr pushed a commit to abc99lr/raft that referenced this pull request May 10, 2024
As part of rapidsai/build-planning#26, warnings in Python tests will be converted to test failures


`ignore:Unknown pytest.mark.ucx:PytestUnknownMarkWarning` could be removed once rapidsai#2281 is merged cc @jameslamb

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#2288
loulankxh pushed a commit to loulankxh/raft that referenced this pull request Oct 14, 2025
As part of rapidsai/build-planning#26, warnings in Python tests will be converted to test failures


`ignore:Unknown pytest.mark.ucx:PytestUnknownMarkWarning` could be removed once rapidsai#2281 is merged cc @jameslamb

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#2288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants