Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

stop uploading packages to downloads.rapids.ai, update to 25.08 workflows#144

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
jameslamb:ci/stop-s3-uploads
May 28, 2025
Merged

stop uploading packages to downloads.rapids.ai, update to 25.08 workflows#144
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
jameslamb:ci/stop-s3-uploads

Conversation

@jameslamb
Copy link
Copy Markdown
Member

Description

Contributes to rapidsai/build-planning#181

Notes for Reviewers

Is it safe to update to branch-25.08 of shared-workflows on main here?

I'm assuming yes, because CI here computes its own custom-to-pynvjitlink support matrices:

compute-matrix:
runs-on: ubuntu-latest
outputs:
BUILD_MATRIX: ${{ steps.compute-matrix.outputs.BUILD_MATRIX }}
steps:
- uses: actions/checkout@v4
- name: Compute Build Matrix
id: compute-matrix
uses: ./.github/actions/compute-matrix

All other non-matrix changes on shared-workflows between branch-25.06 and branch-25.08 should be fine for this repo.

How I identified changes

Looked for uses of the relevant gha-tools tools, as well as documentation about downloads.rapids.ai, being on the NVIDIA VPN, using S3, etc. like this:

git grep -i -E 's3|upload|downloads\.rapids|vpn'

How I tested this

See "How I tested this" on rapidsai/shared-workflows#364

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added breaking Introduces a breaking change improvement Improves an existing functionality labels May 27, 2025
@jameslamb jameslamb changed the title WIP: stop uploading packages to downloads.rapids.ai, update to 25.08 workflows stop uploading packages to downloads.rapids.ai, update to 25.08 workflows May 27, 2025
@jameslamb jameslamb marked this pull request as ready for review May 27, 2025 22:31
@jameslamb jameslamb requested a review from a team as a code owner May 27, 2025 22:31
@jameslamb jameslamb requested a review from gforsyth May 27, 2025 22:31
@jameslamb
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot Bot merged commit c89e6c2 into rapidsai:main May 28, 2025
51 checks passed
@jameslamb jameslamb deleted the ci/stop-s3-uploads branch May 28, 2025 14:55
gmarkall added a commit to gmarkall/pynvjitlink that referenced this pull request Jun 25, 2025
- Raise when pynvjitlink is in use with Numba-CUDA (rapidsai#129)
- Update CI images (update CUDA 12.8.0 to 12.9.1, update Ubuntu 20.04 to 22.04) (rapidsai#147)
- stop uploading packages to downloads.rapids.ai, update to 25.08 workflows (rapidsai#144)
- Update to clang 20 (rapidsai#143)
- Quote head_rev in conda recipes (rapidsai#142)
- Change `PKG_HASH` to `hash` (rapidsai#141)
@gmarkall gmarkall mentioned this pull request Jun 25, 2025
gmarkall added a commit that referenced this pull request Jun 25, 2025
- Raise when pynvjitlink is in use with Numba-CUDA (#129)
- Update CI images (update CUDA 12.8.0 to 12.9.1, update Ubuntu 20.04 to
22.04) (#147)
- stop uploading packages to downloads.rapids.ai, update to 25.08
workflows (#144)
- Update to clang 20 (#143)
- Quote head_rev in conda recipes (#142)
- Change `PKG_HASH` to `hash` (#141)

<!--

Thank you for contributing to pynvjitlink :)

Here are some guidelines to help the review process go smoothly.

1. Please write a description in this text box of the changes that are
being
   made.

2. Please ensure that you have written units tests for the changes
made/features
   added.

3. If you are closing an issue please use one of the automatic closing
words as
noted here:
https://help.github.com/articles/closing-issues-using-keywords/

4. If your pull request is not ready for review but you want to make use
of the
continuous integration testing facilities please label it with `[WIP]`.

5. If your pull request is ready to be reviewed without requiring
additional
work on top of it, then remove the `[WIP]` label (if present) and
replace
it with `[REVIEW]`. If assistance is required to complete the
functionality,
for example when the C/C++ code of a feature is complete but Python
bindings
are still required, then add the label `[HELP-REQ]` so that others can
triage
and assist. The additional changes then can be implemented on top of the
same PR. If the assistance is done by members of the rapidsAI team, then
no
additional actions are required by the creator of the original PR for
this,
otherwise the original author of the PR needs to give permission to the
person(s) assisting to commit to their personal fork of the project. If
that
doesn't happen then a new PR based on the code of the original PR can be
opened by the person assisting, which then will be the PR that will be
   merged.

6. Once all work has been done and review has taken place please do not
add
features or make changes out of the scope of those requested by the
reviewer
(doing this just add delays as already reviewed code ends up having to
be
re-reviewed/it is hard to tell what is new etc!). Further, please do not
rebase your branch on main/force push/rewrite history, doing any of
these
   causes the context of any comments made by reviewers to be lost. If
   conflicts occur against main they should be resolved by merging main
   into the branch used for making the pull request.

Many thanks in advance for your cooperation!

-->
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants