Closed
Conversation
Follow-up to rapidsai/devcontainers#672 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) - James Lamb (https://github.com/jameslamb) Approvers: - James Lamb (https://github.com/jameslamb) URL: #82
Author
|
FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the |
…s, drop CUDA math libraries dependencies (#87) Contributes to rapidsai/build-planning#257 * builds CUDA 13 wheels with the 13.0 CTK Contributes to rapidsai/build-planning#256 * updates wheel tests to cover a range of CTK versions (we previously, accidentally, were only testing the latest 12.x and 13.x) Drops unnecessary CTK dependencies * drops dependencies on cuBLAS, cuFFT, cuRAND, cuSOLVER, and cuSPARSE - *`nvforest` doesn't depend directly on any of these, I suspect they were all just copied over from cuML* * removes related code and configuration Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Philip Hyunsu Cho (https://github.com/hcho3) - Gil Forsyth (https://github.com/gforsyth) URL: #87
github-actions
bot
added
conda
`packaging` is only used in docs builds: https://github.com/rapidsai/nvforest/blob/1dcd17c74f7b03a64a030d5d7460bc3351dd13b1/docs/source/conf.py#L24 and tests: https://github.com/rapidsai/nvforest/blob/1dcd17c74f7b03a64a030d5d7460bc3351dd13b1/python/nvforest/tests/test_nvforest.py#L763 It doesn't need to be declared as a runtime dependency of `nvforest`. This moves it to a test-time-only dependency. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Philip Hyunsu Cho (https://github.com/hcho3) - Gil Forsyth (https://github.com/gforsyth) URL: #88
Member
|
I'll fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.04 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.