Skip to content

handle more RAPIDS version formats in update-version.sh#331

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.04from
jameslamb:update-version
Feb 5, 2024
Merged

handle more RAPIDS version formats in update-version.sh#331
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.04from
jameslamb:update-version

Conversation

@jameslamb
Copy link
Copy Markdown
Member

Contributes to rapidsai/build-planning#13.

Updates update-version.sh to correctly handle RAPIDS dependencies like cudf-cu12==24.2.*.

This project doesn't appear to have any of those right now, but might in the future.

How I tested this

The portability of this updated sed command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

./ci/release/update-version.sh '23.10.00'
git diff

./ci/release/update-version.sh '24.04.00'
git diff

Confirmed that that first git diff changed all the things I expected, and that second one showed 0 changes.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change bug Something isn't working and removed improvement Improves an existing functionality labels Jan 23, 2024
@raydouglass
Copy link
Copy Markdown
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 047ec3e into rapidsai:branch-24.04 Feb 5, 2024
@jameslamb jameslamb deleted the update-version branch February 5, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants