Add fmt and update spdlog in rapids-build-env#624
Merged
ajschmidt8 merged 2 commits intorapidsai:branch-23.04from Feb 21, 2023
Merged
Add fmt and update spdlog in rapids-build-env#624ajschmidt8 merged 2 commits intorapidsai:branch-23.04from
fmt and update spdlog in rapids-build-env#624ajschmidt8 merged 2 commits intorapidsai:branch-23.04from
Conversation
This PR adds the `fmt` conda package to `rapids-build-env`. This change is similar to the changes introduced in rapidsai/rmm#1177 and should help resolve the `devel` image build errors that have been occurring lately (e.g. [these](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/docker/job/rapidsai-core-devel/1888/BUILD_IMAGE=rapidsai%2Frapidsai-core-dev-nightly,CUDA_VER=11.8,FROM_IMAGE=gpuci%2Frapidsai,IMAGE_TYPE=devel,LINUX_VER=ubuntu22.04,PYTHON_VER=3.10,RAPIDS_VER=23.04/console)).
ajschmidt8
changed the title
fmt to rapids-build-envfmt and update spdlog in rapids-build-env
robertmaynard
approved these changes
Feb 21, 2023
jjacobelli
approved these changes
Feb 21, 2023
bdice
approved these changes
Feb 21, 2023
AyodeAwe
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
fmtconda package torapids-build-env. It also updates thespdlogversion specifier.These changes are similar to the changes introduced in rapidsai/rmm#1177 and should help resolve the
develimage build errors that have been occurring lately (e.g. these).