Skip to content

Conversation

@madsbk
Copy link
Member

@madsbk madsbk commented May 4, 2022

Now that cudf.merge_sorted() is deprecated in cuDF, we should remove its test.

Closes #904

now that it is deprecated in cuDF.
@madsbk madsbk requested a review from a team as a code owner May 4, 2022 13:36
@github-actions github-actions bot added the python python code needed label May 4, 2022
@madsbk madsbk added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 4, 2022
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @madsbk !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8235301 into rapidsai:branch-22.06 May 4, 2022
@madsbk madsbk deleted the remove_test_merge_sorted_of_proxied_cudf_dataframes branch January 24, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning in test_merge_sorted_of_proxied_cudf_dataframes

2 participants