Increase spill tests timeout to 30 seconds #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
bug
jjacobelli
approved these changes
Apr 26, 2022
madsbk
approved these changes
Apr 26, 2022
Member
madsbk
left a comment
madsbk
left a comment
There was a problem hiding this comment.
LGTM, but maybe increase to 60 sec just to be on the safe side?
Member
Author
I think 60 seconds may be too much, if we really need to increase that high, maybe we should consider redesigning tests so that they run faster. TBH, 30 seconds already feels too high for me, but spilling is hard to keep that much under. |
Member
Author
Member
Author
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeouts have occurred already in a few gpuCI instances, and locally those are consistently reproducible when the spill test is the first to run, where it takes just over 20 seconds probably due to added overhead of CUDA context creation. Increasing the timeout to 30 seconds seems sufficient.