This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Unpin py-xgboost in dask-sql CI #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could we move to XGBoost 2? |
This was referenced Mar 14, 2024
Member
Author
|
I think so, testing this out against CI here: dask-contrib/dask-sql#1314 If things pass there can go ahead and merge and close this |
jakirkham
approved these changes
Mar 14, 2024
Member
|
Looks like things passed for Dask-SQL based on Charles' testing. Approving |
Member
Author
|
Thanks @jakirkham! I'm going to retry the dask-sql builds locally to see if dask-contrib/dask-sql#1314 unblocks things, if so should be good to close this |
Member
|
Certainly merge at your discretion 🙂 |
Member
Author
|
Verified that with dask-contrib/dask-sql#1314 and #88, builds should be unblocked - closing this out |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks the build failures that result from the addition of
py-xgboost=1.7.0to dask-sql's 3.9 environment in dask-contrib/dask-sql#1301.