updates to external tests#547
Merged
rapids-bot[bot] merged 3 commits intoOct 17, 2023
Merged
Conversation
AjayThorve
added
non-breaking
AjayThorve
force-pushed
the
external-testing-workflow
branch
from
876ed56 to
9730ded
Compare
AjayThorve
force-pushed
the
external-testing-workflow
branch
from
9730ded to
fa780d2
Compare
raydouglass
approved these changes
Oct 17, 2023
Contributor
raydouglass
left a comment
raydouglass
left a comment
There was a problem hiding this comment.
Approving since the external_dependencies.yaml file already exists.
But, a future enhancement should be to move the external dependencies env file to be a file key in dependencies.yaml instead.
Member
Author
|
/merge |
Member
Author
I'll do a follow up PR with this, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the external tests still failing: https://github.com/rapidsai/cuxfilter/actions/runs/6485671242/job/17612261430.
Basically separately installing direct dependencies and then installing indirect dependencies from dependencies.yaml was downgrading rapids versions to 23.08 separately. This PR updates the dependencies to be in a single place (external_dependencies.yaml), while also adding it to
ci/release/update-version.shThere were a couple of dask.array tests in datashader which were failing when using
pytestwith--numprocessesflag, which is resolved here by separately running that test without the flag.cc @exactlyallan