Skip to content

Build CUDA 12.0 ARM conda packages.#542

Merged
rapids-bot[bot] merged 3 commits into
rapidsai:branch-23.12from
bdice:cuda-120-arm
Oct 4, 2023
Merged

Build CUDA 12.0 ARM conda packages.#542
rapids-bot[bot] merged 3 commits into
rapidsai:branch-23.12from
bdice:cuda-120-arm

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Oct 4, 2023

This PR builds conda packages using CUDA 12 on ARM.

Closes #538.

@bdice bdice marked this pull request as ready for review October 4, 2023 01:10
@bdice bdice requested a review from a team as a code owner October 4, 2023 01:10
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Oct 4, 2023

There are some false positives from flake8 with Python 3.12. It thinks that CSS embedded in f-strings should abide by Python syntax rules, which isn't right. I fixed this by pinning the Python version in style checks, like we already do for all other RAPIDS repositories. See 36dbdc1 for the fix. I don't see this with flake8 in Python 3.10 when running locally, but I can replicate it with Python 3.12.

https://github.com/rapidsai/cuxfilter/actions/runs/6400679208/job/17374621796?pr=542#step:6:147

Details
2023-10-04T02:07:37.9354125Z python/cuxfilter/charts/core/core_widget.py:141:58: E702 multiple statements on one line (semicolon)
2023-10-04T02:07:37.9354755Z python/cuxfilter/charts/core/core_widget.py:141:58: E231 missing whitespace after ';'
2023-10-04T02:07:37.9356064Z python/cuxfilter/charts/core/core_widget.py:142:0: E241 multiple spaces after ';'
2023-10-04T02:07:37.9356489Z python/cuxfilter/charts/core/core_widget.py:142:54: E702 multiple statements on one line (semicolon)
2023-10-04T02:07:37.9357014Z python/cuxfilter/charts/core/core_widget.py:142:54: E231 missing whitespace after ';'
2023-10-04T02:07:37.9357498Z python/cuxfilter/charts/core/core_widget.py:143:0: E241 multiple spaces after ';'
2023-10-04T02:07:37.9357976Z python/cuxfilter/charts/core/core_widget.py:143:16: E202 whitespace before '}'
2023-10-04T02:07:37.9359009Z python/cuxfilter/charts/core/core_widget.py:146:-1: E702 multiple statements on one line (semicolon)
2023-10-04T02:07:37.9359486Z python/cuxfilter/charts/core/core_widget.py:146:-1: E231 missing whitespace after ';'
2023-10-04T02:07:37.9360413Z python/cuxfilter/charts/core/core_widget.py:146:0: E241 multiple spaces after ';'
2023-10-04T02:07:37.9361010Z python/cuxfilter/charts/core/core_widget.py:146:16: E202 whitespace before '}'
2023-10-04T02:07:37.9361626Z python/cuxfilter/charts/core/non_aggregate/core_non_aggregate.py:34:19: E226 missing whitespace around arithmetic operator
2023-10-04T02:07:37.9362334Z python/cuxfilter/charts/core/non_aggregate/core_non_aggregate.py:35:19: E226 missing whitespace around arithmetic operator
2023-10-04T02:07:37.9363724Z python/cuxfilter/charts/panel_widgets/plots.py:421:58: E702 multiple statements on one line (semicolon)
2023-10-04T02:07:37.9364343Z python/cuxfilter/charts/panel_widgets/plots.py:421:58: E231 missing whitespace after ';'
2023-10-04T02:07:37.9364854Z python/cuxfilter/charts/panel_widgets/plots.py:422:0: E241 multiple spaces after ';'
2023-10-04T02:07:37.9365287Z python/cuxfilter/charts/panel_widgets/plots.py:422:54: E702 multiple statements on one line (semicolon)
2023-10-04T02:07:37.9365806Z python/cuxfilter/charts/panel_widgets/plots.py:422:54: E231 missing whitespace after ';'
2023-10-04T02:07:37.9366309Z python/cuxfilter/charts/panel_widgets/plots.py:423:0: E241 multiple spaces after ';'
2023-10-04T02:07:37.9367135Z python/cuxfilter/charts/panel_widgets/plots.py:423:16: E202 whitespace before '}'
2023-10-04T02:07:37.9367798Z python/cuxfilter/charts/panel_widgets/plots.py:425:-1: E231 missing whitespace after ','
2023-10-04T02:07:37.9368240Z python/cuxfilter/charts/panel_widgets/plots.py:425:0: E241 multiple spaces after ','
2023-10-04T02:07:37.9368730Z python/cuxfilter/charts/panel_widgets/plots.py:427:-1: E702 multiple statements on one line (semicolon)
2023-10-04T02:07:37.9369479Z python/cuxfilter/charts/panel_widgets/plots.py:427:-1: E231 missing whitespace after ';'
2023-10-04T02:07:37.9369968Z python/cuxfilter/charts/panel_widgets/plots.py:427:0: E241 multiple spaces after ';'
2023-10-04T02:07:37.9370416Z python/cuxfilter/charts/panel_widgets/plots.py:427:16: E202 whitespace before '}'
2023-10-04T02:07:37.9370803Z python/cuxfilter/charts/panel_widgets/plots.py:429:58: E221 multiple spaces before operator
2023-10-04T02:07:37.9371302Z python/cuxfilter/charts/panel_widgets/plots.py:431:-1: E702 multiple statements on one line (semicolon)
2023-10-04T02:07:37.9371765Z python/cuxfilter/charts/panel_widgets/plots.py:431:-1: E231 missing whitespace after ';'
2023-10-04T02:07:37.9372382Z python/cuxfilter/charts/panel_widgets/plots.py:431:0: E241 multiple spaces after ';'
2023-10-04T02:07:37.9372832Z python/cuxfilter/charts/panel_widgets/plots.py:432:-1: E702 multiple statements on one line (semicolon)
2023-10-04T02:07:37.9373266Z python/cuxfilter/charts/panel_widgets/plots.py:432:-1: E231 missing whitespace after ';'
2023-10-04T02:07:37.9373690Z python/cuxfilter/charts/panel_widgets/plots.py:432:0: E241 multiple spaces after ';'
2023-10-04T02:07:37.9374103Z python/cuxfilter/charts/panel_widgets/plots.py:432:16: E202 whitespace before '}'

@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 4, 2023
@raydouglass
Copy link
Copy Markdown
Contributor

/merge

@rapids-bot rapids-bot Bot merged commit fa94db6 into rapidsai:branch-23.12 Oct 4, 2023
@AjayThorve
Copy link
Copy Markdown
Member

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants