fix reinit function#345
Merged
rapids-bot[bot] merged 2 commits intoJan 24, 2022
Merged
Conversation
Contributor
|
@AjayThorve is there a good test case or example to run to see before/after? Changes look OK at a glance but I don't really have any context for what exactly was broken |
Member
Author
|
@bryevdv (pushed one more change after you reviewed). basically don't need to reinitialize Current implementation was reinitializing it twice (line 320, 325), and this was leading to some inconsistencies in data size values if we ran Ideally, it should just reinitialize all charts if we rerun the function, which now happens properly |
bryevdv
approved these changes
Jan 20, 2022
Member
Author
|
@gpucibot merge |
Member
Author
|
rerun tests |
1 similar comment
Member
Author
|
rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix PR to fix the
_reinit_all_chartsfunction, which was no longer working due to the recent refactors