Skip to content

fix reinit function#345

Merged
rapids-bot[bot] merged 2 commits into
rapidsai:branch-22.02from
AjayThorve:fix/reinit_charts
Jan 24, 2022
Merged

fix reinit function#345
rapids-bot[bot] merged 2 commits into
rapidsai:branch-22.02from
AjayThorve:fix/reinit_charts

Conversation

@AjayThorve
Copy link
Copy Markdown
Member

Quick fix PR to fix the _reinit_all_charts function, which was no longer working due to the recent refactors

@AjayThorve AjayThorve requested a review from a team as a code owner January 20, 2022 21:53
@AjayThorve AjayThorve requested a review from bryevdv January 20, 2022 21:54
@AjayThorve AjayThorve added bug Something isn't working non-breaking Non-breaking change labels Jan 20, 2022
@bryevdv
Copy link
Copy Markdown
Contributor

bryevdv commented Jan 20, 2022

@AjayThorve is there a good test case or example to run to see before/after? Changes look OK at a glance but I don't really have any context for what exactly was broken

@AjayThorve
Copy link
Copy Markdown
Member Author

AjayThorve commented Jan 20, 2022

@bryevdv (pushed one more change after you reviewed). basically don't need to reinitialize data_size_indicator, separately, as that was fixed in a previous PR.

Current implementation was reinitializing it twice (line 320, 325), and this was leading to some inconsistencies in data size values if we ran d.app() twice, or d.show() twice in a row.

Ideally, it should just reinitialize all charts if we rerun the function, which now happens properly

@AjayThorve
Copy link
Copy Markdown
Member Author

@gpucibot merge

@AjayThorve
Copy link
Copy Markdown
Member Author

rerun tests

1 similar comment
@AjayThorve
Copy link
Copy Markdown
Member Author

rerun tests

@rapids-bot rapids-bot Bot merged commit 4c9e69d into rapidsai:branch-22.02 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants