Fix the launch bounds for nn-descent kernel for __CUDA_ARCH__ 1210#965
Closed
achirkin wants to merge 1 commit intobranch-25.08from
Closed
Fix the launch bounds for nn-descent kernel for __CUDA_ARCH__ 1210#965achirkin wants to merge 1 commit intobranch-25.08from
achirkin wants to merge 1 commit intobranch-25.08from
Conversation
achirkin
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.08 #965 +/- ##
===============================================
Coverage ? 83.20%
===============================================
Files ? 21
Lines ? 131
Branches ? 0
===============================================
Hits ? 109
Misses ? 22
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
divyegala
approved these changes
May 30, 2025
Member
|
Given this is a simple fix, could we target for 25.06? |
Contributor
Author
|
closing in favor of #967 |
copy-pr-bot Bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
Backport of #965 Invert the CUDA_ARCH logic Fix == Fix style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix to make cuVS build for a target architecture 1210